Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2812893002: [Reland] Use dropdown list for admin areas in pr form. (Closed)

Created:
3 years, 8 months ago by Parastoo
Modified:
3 years, 8 months ago
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland explanation: crrev.com/2680143002 caused chrome_public_test_apk failing on chromium.android/Marshmallow. The problem is fixed in this CL. To make the payment request tests independent of the network status, the tests set the time-out = 0, which means that the sub-keys must never be fetched, and the address forms will always show a textfield, and not a dropdown for the admin areas. In the previous CL, the time-out would start after the request. => For some entities (with network connection), subkeys were already fetched, before the timeout had started. => A dropdown would show. To solve this, the order was changed. Now the time-out starts before the request. BUG=709491 Review-Url: https://codereview.chromium.org/2812893002 Cr-Commit-Position: refs/heads/master@{#463945} Committed: https://chromium.googlesource.com/chromium/src/+/886089f3cad28e46fa21e3d73c60fd5e87d7621f

Patch Set 1 : Original CL 268013002 #

Patch Set 2 : Start the time-out before the sub-key request. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -96 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 8 chunks +60 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java View 1 11 chunks +161 lines, -58 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 4 chunks +10 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java View 1 chunk +22 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 4 chunks +52 lines, -2 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 7 chunks +98 lines, -3 lines 0 comments Download
M components/payments/core/address_normalizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/payments/core/address_normalizer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator.h View 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator.cc View 4 chunks +17 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc View 7 chunks +27 lines, -8 lines 0 comments Download

Messages

Total messages: 30 (21 generated)
Parastoo
3 years, 8 months ago (2017-04-11 16:32:16 UTC) #13
sebsg
Makes sense, thanks for the fix. I would change the name to something like "Reland ...
3 years, 8 months ago (2017-04-11 17:04:06 UTC) #18
Mathieu
lgtm
3 years, 8 months ago (2017-04-11 18:35:02 UTC) #20
Parastoo
3 years, 8 months ago (2017-04-11 19:25:12 UTC) #22
gone
lgtm
3 years, 8 months ago (2017-04-11 20:03:00 UTC) #23
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-11 21:14:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812893002/40001
3 years, 8 months ago (2017-04-12 06:59:39 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/886089f3cad28e46fa21e3d73c60fd5e87d7621f
3 years, 8 months ago (2017-04-12 07:45:31 UTC) #29
Donn Denman
3 years, 8 months ago (2017-04-12 17:20:55 UTC) #30
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2817733002/ by donnd@chromium.org.

The reason for reverting is: Still some lingering test failures.  See
crbug.com/710911.

Powered by Google App Engine
This is Rietveld 408576698