Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2817713002:
Ignore unknown focusable nodes if they have children (Closed)
|
Created:
3 years, 8 months ago by David Tseng Modified:
3 years, 8 months ago Reviewers:
dmazzoni CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionIgnore unknown focusable nodes if they have children
BUG=710892, 707927
TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). Also, verify that ChromeVox never lands on the unknown node directly and does not mention it in ancestry summarization.
Review-Url: https://codereview.chromium.org/2817713002
Cr-Commit-Position: refs/heads/master@{#464168}
Committed: https://chromium.googlesource.com/chromium/src/+/72bb94a66c02d96c6a4b258ce7e8c5ebb0272273
Patch Set 1 #Patch Set 2 : Simpler fix (unknown nodes are structural containers). #Messages
Total messages: 12 (7 generated)
Description was changed from ========== Ignore unknown focusable nodes if they have children TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). <table class="GS" tabindex="-1"><tbody><tr><td class="ok"><div class="o1"><span id=":78" class="gO aQY" data-tooltip="Select Contacts" aria-label="To - Select Contacts" role="link" tabindex="1">To</span></div></td><td class="eV"><div id=":77" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3q" email="theophilusx@gmail.com"><div class="vT">Tim Cross (gmail.com)</div><div class="vM"></div></span><input name="to" type="hidden" value="Tim Cross <theophilusx@gmail.com>"></div><textarea rows="1" id=":7j" class="vO" name="to" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="To" role="combobox" aria-autocomplete="list"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4q"><td class="ok"><span id=":4p" class="gO aQY" data-tooltip="Select Contacts" aria-label="Cc - Select Contacts" role="link" tabindex="1">Cc</span></td><td class="eV"><div id=":4o" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3p" email="doggene@earthlink.net"><div class="vT">Liz Hare (doggene@earthlink.net)</div><div class="vM"></div></span><input name="cc" type="hidden" value="Liz Hare <doggene@earthlink.net>"></div><div class="vR"><span class="vN bfK a3p" email="emacspeak@cs.vassar.edu"><div class="vT">emacspeak (emacspeak@cs.vassar.edu)</div><div class="vM"></div></span><input name="cc" type="hidden" value="emacspeak <emacspeak@cs.vassar.edu>"></div><textarea rows="1" id=":7k" class="vO" name="cc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Cc" role="combobox" aria-autocomplete="list" style="width: 0px;"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4k" style="display:none"><td class="ok"><span id=":4j" class="gO aQY" data-tooltip="Select Contacts" aria-label="Bcc - Select Contacts" role="link" tabindex="1">Bcc</span></td><td class="eV"><div id=":4i" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><textarea rows="1" id=":7l" class="vO" name="bcc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Bcc"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":5g"><td class="ok az4"><label for=":4r" class="gO">From</label></td><td id=":4t" class="az3"><div id=":4r" class="J-JN-M-I J-J5-Ji az2 az4 L3" role="button" tabindex="1" aria-haspopup="true" aria-expanded="false" style="user-select: none;"><div class="J-J5-Ji J-JN-M-I-Jm"><span dir="ltr" id=":4x">user@gmail.com</span></div><div class="J-J5-Ji J-JN-M-I-JG"></div></div><div id=":5f" class="ow"><span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><span><span id=":4c" class="aB gQ pE" role="link" tabindex="1" data-tooltip="Add Cc Recipients (Ctrl-Shift-C)" aria-label="Add Cc Recipients (Ctrl-Shift-C)" style="user-select: none; display: none;">Cc</span><span id=":4b" class="aB gQ pB" role="link" tabindex="1" data-tooltip="Add Bcc Recipients (Ctrl-Shift-B)" aria-label="Add Bcc Recipients (Ctrl-Shift-B)" style="user-select: none;">Bcc</span><span id=":6j" role="button" tabindex="1" aria-hidden="false" class="bcV" style="visibility: visible; display: none;" data-tooltip="Some recipients use services that don't support encryption (click for details)" aria-label="Some recipients use services that don't support encryption (click for details)"></span></span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div></span></div></td></tr><tr id=":4l" style="display:none"><td></td><td><div id=":80" class="az7" style="user-select: none;"></div><div id=":75" class="ow"></div></td></tr></tbody></table> BUG= ========== to ========== Ignore unknown focusable nodes if they have children TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). <table class="GS" tabindex="-1"><tbody><tr><td class="ok"><div class="o1"><span id=":78" class="gO aQY" data-tooltip="Select Contacts" aria-label="To - Select Contacts" role="link" tabindex="1">To</span></div></td><td class="eV"><div id=":77" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3q" email="theophilusx@gmail.com"><div class="vT">Tim Cross (gmail.com)</div><div class="vM"></div></span><input name="to" type="hidden" value="Tim Cross <theophilusx@gmail.com>"></div><textarea rows="1" id=":7j" class="vO" name="to" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="To" role="combobox" aria-autocomplete="list"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4q"><td class="ok"><span id=":4p" class="gO aQY" data-tooltip="Select Contacts" aria-label="Cc - Select Contacts" role="link" tabindex="1">Cc</span></td><td class="eV"><div id=":4o" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3p" email="doggene@earthlink.net"><div class="vT">Liz Hare (doggene@earthlink.net)</div><div class="vM"></div></span><input name="cc" type="hidden" value="Liz Hare <doggene@earthlink.net>"></div><div class="vR"><span class="vN bfK a3p" email="emacspeak@cs.vassar.edu"><div class="vT">emacspeak (emacspeak@cs.vassar.edu)</div><div class="vM"></div></span><input name="cc" type="hidden" value="emacspeak <emacspeak@cs.vassar.edu>"></div><textarea rows="1" id=":7k" class="vO" name="cc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Cc" role="combobox" aria-autocomplete="list" style="width: 0px;"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4k" style="display:none"><td class="ok"><span id=":4j" class="gO aQY" data-tooltip="Select Contacts" aria-label="Bcc - Select Contacts" role="link" tabindex="1">Bcc</span></td><td class="eV"><div id=":4i" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><textarea rows="1" id=":7l" class="vO" name="bcc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Bcc"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":5g"><td class="ok az4"><label for=":4r" class="gO">From</label></td><td id=":4t" class="az3"><div id=":4r" class="J-JN-M-I J-J5-Ji az2 az4 L3" role="button" tabindex="1" aria-haspopup="true" aria-expanded="false" style="user-select: none;"><div class="J-J5-Ji J-JN-M-I-Jm"><span dir="ltr" id=":4x">user@gmail.com</span></div><div class="J-J5-Ji J-JN-M-I-JG"></div></div><div id=":5f" class="ow"><span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><span><span id=":4c" class="aB gQ pE" role="link" tabindex="1" data-tooltip="Add Cc Recipients (Ctrl-Shift-C)" aria-label="Add Cc Recipients (Ctrl-Shift-C)" style="user-select: none; display: none;">Cc</span><span id=":4b" class="aB gQ pB" role="link" tabindex="1" data-tooltip="Add Bcc Recipients (Ctrl-Shift-B)" aria-label="Add Bcc Recipients (Ctrl-Shift-B)" style="user-select: none;">Bcc</span><span id=":6j" role="button" tabindex="1" aria-hidden="false" class="bcV" style="visibility: visible; display: none;" data-tooltip="Some recipients use services that don't support encryption (click for details)" aria-label="Some recipients use services that don't support encryption (click for details)"></span></span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div></span></div></td></tr><tr id=":4l" style="display:none"><td></td><td><div id=":80" class="az7" style="user-select: none;"></div><div id=":75" class="ow"></div></td></tr></tbody></table> BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Ignore unknown focusable nodes if they have children TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). <table class="GS" tabindex="-1"><tbody><tr><td class="ok"><div class="o1"><span id=":78" class="gO aQY" data-tooltip="Select Contacts" aria-label="To - Select Contacts" role="link" tabindex="1">To</span></div></td><td class="eV"><div id=":77" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3q" email="theophilusx@gmail.com"><div class="vT">Tim Cross (gmail.com)</div><div class="vM"></div></span><input name="to" type="hidden" value="Tim Cross <theophilusx@gmail.com>"></div><textarea rows="1" id=":7j" class="vO" name="to" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="To" role="combobox" aria-autocomplete="list"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4q"><td class="ok"><span id=":4p" class="gO aQY" data-tooltip="Select Contacts" aria-label="Cc - Select Contacts" role="link" tabindex="1">Cc</span></td><td class="eV"><div id=":4o" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3p" email="doggene@earthlink.net"><div class="vT">Liz Hare (doggene@earthlink.net)</div><div class="vM"></div></span><input name="cc" type="hidden" value="Liz Hare <doggene@earthlink.net>"></div><div class="vR"><span class="vN bfK a3p" email="emacspeak@cs.vassar.edu"><div class="vT">emacspeak (emacspeak@cs.vassar.edu)</div><div class="vM"></div></span><input name="cc" type="hidden" value="emacspeak <emacspeak@cs.vassar.edu>"></div><textarea rows="1" id=":7k" class="vO" name="cc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Cc" role="combobox" aria-autocomplete="list" style="width: 0px;"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4k" style="display:none"><td class="ok"><span id=":4j" class="gO aQY" data-tooltip="Select Contacts" aria-label="Bcc - Select Contacts" role="link" tabindex="1">Bcc</span></td><td class="eV"><div id=":4i" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><textarea rows="1" id=":7l" class="vO" name="bcc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Bcc"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":5g"><td class="ok az4"><label for=":4r" class="gO">From</label></td><td id=":4t" class="az3"><div id=":4r" class="J-JN-M-I J-J5-Ji az2 az4 L3" role="button" tabindex="1" aria-haspopup="true" aria-expanded="false" style="user-select: none;"><div class="J-J5-Ji J-JN-M-I-Jm"><span dir="ltr" id=":4x">user@gmail.com</span></div><div class="J-J5-Ji J-JN-M-I-JG"></div></div><div id=":5f" class="ow"><span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><span><span id=":4c" class="aB gQ pE" role="link" tabindex="1" data-tooltip="Add Cc Recipients (Ctrl-Shift-C)" aria-label="Add Cc Recipients (Ctrl-Shift-C)" style="user-select: none; display: none;">Cc</span><span id=":4b" class="aB gQ pB" role="link" tabindex="1" data-tooltip="Add Bcc Recipients (Ctrl-Shift-B)" aria-label="Add Bcc Recipients (Ctrl-Shift-B)" style="user-select: none;">Bcc</span><span id=":6j" role="button" tabindex="1" aria-hidden="false" class="bcV" style="visibility: visible; display: none;" data-tooltip="Some recipients use services that don't support encryption (click for details)" aria-label="Some recipients use services that don't support encryption (click for details)"></span></span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div></span></div></td></tr><tr id=":4l" style="display:none"><td></td><td><div id=":80" class="az7" style="user-select: none;"></div><div id=":75" class="ow"></div></td></tr></tbody></table> BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Ignore unknown focusable nodes if they have children BUG=710892,707927 TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). <table class="GS" tabindex="-1"><tbody><tr><td class="ok"><div class="o1"><span id=":78" class="gO aQY" data-tooltip="Select Contacts" aria-label="To - Select Contacts" role="link" tabindex="1">To</span></div></td><td class="eV"><div id=":77" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3q" email="theophilusx@gmail.com"><div class="vT">Tim Cross (gmail.com)</div><div class="vM"></div></span><input name="to" type="hidden" value="Tim Cross <theophilusx@gmail.com>"></div><textarea rows="1" id=":7j" class="vO" name="to" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="To" role="combobox" aria-autocomplete="list"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4q"><td class="ok"><span id=":4p" class="gO aQY" data-tooltip="Select Contacts" aria-label="Cc - Select Contacts" role="link" tabindex="1">Cc</span></td><td class="eV"><div id=":4o" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3p" email="doggene@earthlink.net"><div class="vT">Liz Hare (doggene@earthlink.net)</div><div class="vM"></div></span><input name="cc" type="hidden" value="Liz Hare <doggene@earthlink.net>"></div><div class="vR"><span class="vN bfK a3p" email="emacspeak@cs.vassar.edu"><div class="vT">emacspeak (emacspeak@cs.vassar.edu)</div><div class="vM"></div></span><input name="cc" type="hidden" value="emacspeak <emacspeak@cs.vassar.edu>"></div><textarea rows="1" id=":7k" class="vO" name="cc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Cc" role="combobox" aria-autocomplete="list" style="width: 0px;"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4k" style="display:none"><td class="ok"><span id=":4j" class="gO aQY" data-tooltip="Select Contacts" aria-label="Bcc - Select Contacts" role="link" tabindex="1">Bcc</span></td><td class="eV"><div id=":4i" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><textarea rows="1" id=":7l" class="vO" name="bcc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Bcc"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":5g"><td class="ok az4"><label for=":4r" class="gO">From</label></td><td id=":4t" class="az3"><div id=":4r" class="J-JN-M-I J-J5-Ji az2 az4 L3" role="button" tabindex="1" aria-haspopup="true" aria-expanded="false" style="user-select: none;"><div class="J-J5-Ji J-JN-M-I-Jm"><span dir="ltr" id=":4x">user@gmail.com</span></div><div class="J-J5-Ji J-JN-M-I-JG"></div></div><div id=":5f" class="ow"><span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><span><span id=":4c" class="aB gQ pE" role="link" tabindex="1" data-tooltip="Add Cc Recipients (Ctrl-Shift-C)" aria-label="Add Cc Recipients (Ctrl-Shift-C)" style="user-select: none; display: none;">Cc</span><span id=":4b" class="aB gQ pB" role="link" tabindex="1" data-tooltip="Add Bcc Recipients (Ctrl-Shift-B)" aria-label="Add Bcc Recipients (Ctrl-Shift-B)" style="user-select: none;">Bcc</span><span id=":6j" role="button" tabindex="1" aria-hidden="false" class="bcV" style="visibility: visible; display: none;" data-tooltip="Some recipients use services that don't support encryption (click for details)" aria-label="Some recipients use services that don't support encryption (click for details)"></span></span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div></span></div></td></tr><tr id=":4l" style="display:none"><td></td><td><div id=":80" class="az7" style="user-select: none;"></div><div id=":75" class="ow"></div></td></tr></tbody></table> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
Note the underlying issue (which was filed as bug 710892). PTAL
Description was changed from ========== Ignore unknown focusable nodes if they have children BUG=710892,707927 TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). <table class="GS" tabindex="-1"><tbody><tr><td class="ok"><div class="o1"><span id=":78" class="gO aQY" data-tooltip="Select Contacts" aria-label="To - Select Contacts" role="link" tabindex="1">To</span></div></td><td class="eV"><div id=":77" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3q" email="theophilusx@gmail.com"><div class="vT">Tim Cross (gmail.com)</div><div class="vM"></div></span><input name="to" type="hidden" value="Tim Cross <theophilusx@gmail.com>"></div><textarea rows="1" id=":7j" class="vO" name="to" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="To" role="combobox" aria-autocomplete="list"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4q"><td class="ok"><span id=":4p" class="gO aQY" data-tooltip="Select Contacts" aria-label="Cc - Select Contacts" role="link" tabindex="1">Cc</span></td><td class="eV"><div id=":4o" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><div class="vR"><span class="vN bfK a3p" email="doggene@earthlink.net"><div class="vT">Liz Hare (doggene@earthlink.net)</div><div class="vM"></div></span><input name="cc" type="hidden" value="Liz Hare <doggene@earthlink.net>"></div><div class="vR"><span class="vN bfK a3p" email="emacspeak@cs.vassar.edu"><div class="vT">emacspeak (emacspeak@cs.vassar.edu)</div><div class="vM"></div></span><input name="cc" type="hidden" value="emacspeak <emacspeak@cs.vassar.edu>"></div><textarea rows="1" id=":7k" class="vO" name="cc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Cc" role="combobox" aria-autocomplete="list" style="width: 0px;"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":4k" style="display:none"><td class="ok"><span id=":4j" class="gO aQY" data-tooltip="Select Contacts" aria-label="Bcc - Select Contacts" role="link" tabindex="1">Bcc</span></td><td class="eV"><div id=":4i" class="oj"><div class="wO nr"><input class="wA" tabindex="-1" aria-hidden="true"><textarea rows="1" id=":7l" class="vO" name="bcc" spellcheck="false" autocomplete="false" autocapitalize="off" autocorrect="off" tabindex="1" dir="ltr" aria-label="Bcc"></textarea><div class="aA6"></div></div></div></td></tr><tr id=":5g"><td class="ok az4"><label for=":4r" class="gO">From</label></td><td id=":4t" class="az3"><div id=":4r" class="J-JN-M-I J-J5-Ji az2 az4 L3" role="button" tabindex="1" aria-haspopup="true" aria-expanded="false" style="user-select: none;"><div class="J-J5-Ji J-JN-M-I-Jm"><span dir="ltr" id=":4x">user@gmail.com</span></div><div class="J-J5-Ji J-JN-M-I-JG"></div></div><div id=":5f" class="ow"><span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div><span><span id=":4c" class="aB gQ pE" role="link" tabindex="1" data-tooltip="Add Cc Recipients (Ctrl-Shift-C)" aria-label="Add Cc Recipients (Ctrl-Shift-C)" style="user-select: none; display: none;">Cc</span><span id=":4b" class="aB gQ pB" role="link" tabindex="1" data-tooltip="Add Bcc Recipients (Ctrl-Shift-B)" aria-label="Add Bcc Recipients (Ctrl-Shift-B)" style="user-select: none;">Bcc</span><span id=":6j" role="button" tabindex="1" aria-hidden="false" class="bcV" style="visibility: visible; display: none;" data-tooltip="Some recipients use services that don't support encryption (click for details)" aria-label="Some recipients use services that don't support encryption (click for details)"></span></span><div tabindex="1" style="width: 1px; height: 1px; position: absolute;"></div></span></div></td></tr><tr id=":4l" style="display:none"><td></td><td><div id=":80" class="az7" style="user-select: none;"></div><div id=":75" class="ow"></div></td></tr></tbody></table> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Ignore unknown focusable nodes if they have children BUG=710892,707927 TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). Also, verify that ChromeVox never lands on the unknown node directly and does not mention it in ancestry summarization. ==========
lgtm I think the issue is that it's a layout table, but the tabindex means we can't ignore it. Could you fix it in Blink so that we return a role of DIV or GROUP or something like that rather than UNKNOWN?
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On Wed, Apr 12, 2017 at 1:38 PM, <dmazzoni@chromium.org> wrote: > lgtm > > I think the issue is that it's a layout table, but > the tabindex means we can't ignore it. > > Could you fix it in Blink so that we return a role > of DIV or GROUP or something like that rather than > UNKNOWN? > > We should probably think through what the mapping should be in this case. div is almost as bad as unknown. Perhaps discuss on the bug. > https://codereview.chromium.org/2817713002/ > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to chromium-reviews+unsubscribe@chromium.org. > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492030293913680,
"parent_rev": "aad37ecd104724b8fae303f241c9ce8af45a1fc1", "commit_rev":
"72bb94a66c02d96c6a4b258ce7e8c5ebb0272273"}
Message was sent while issue was closed.
Description was changed from ========== Ignore unknown focusable nodes if they have children BUG=710892,707927 TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). Also, verify that ChromeVox never lands on the unknown node directly and does not mention it in ancestry summarization. ========== to ========== Ignore unknown focusable nodes if they have children BUG=710892,707927 TEST=navigate by object in Gmail's compose view. Verify that object navigation doesn't skip the "unknown" node which contains the contents of the form (e.g. to, from, etc). Also, verify that ChromeVox never lands on the unknown node directly and does not mention it in ancestry summarization. Review-Url: https://codereview.chromium.org/2817713002 Cr-Commit-Position: refs/heads/master@{#464168} Committed: https://chromium.googlesource.com/chromium/src/+/72bb94a66c02d96c6a4b258ce7e8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/72bb94a66c02d96c6a4b258ce7e8... |
