chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js - Issue 2817713002: Ignore unknown focusable nodes if they have children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

Issue 2817713002: Ignore unknown focusable nodes if they have children (Closed)

Patch Set: Simpler fix (unknown nodes are structural containers). Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

index 2208f0bb661352b97e338298f7e1156b41cec98d..717e78e7845308509d90b65b5791e526ed18be2c 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

@@ -313,7 +313,8 @@ AutomationPredicate.structuralContainer = AutomationPredicate.roles([

Role.WINDOW,

Role.EMBEDDED_OBJECT,

Role.IFRAME,

- Role.IFRAME_PRESENTATIONAL]);

+ Role.IFRAME_PRESENTATIONAL,

+ Role.UNKNOWN]);

/**

* Returns whether the given node should not be crossed when performing

« no previous file with comments | « no previous file | no next file » | no next file with comments »