Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2817583004: rebaseline-cl: Enable filling in missing results if no results could be fetched. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
wkorman
CC:
blink-reviews, chromium-reviews, jeffcarp
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

rebaseline-cl: Enable filling in missing results if no results could be fetched. The previous CL (https://codereview.chromium.org/2803143002) added most of the logic for filling in missing results, but for cases where a build exist but has no results (e.g. infra failures, unfinished builds), the rebaseline-cl command would still abort; this CL changes it so that if --fill-missing is given, rebaseline-cl will still continue after results were not found for some existing builds. BUG=673966 Review-Url: https://codereview.chromium.org/2817583004 Cr-Commit-Position: refs/heads/master@{#464587} Committed: https://chromium.googlesource.com/chromium/src/+/ed4ab0401c27e0643fa370fc3d61e5781099ab69

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 1 chunk +18 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
qyearsley
3 years, 8 months ago (2017-04-12 19:29:04 UTC) #4
wkorman
lgtm https://codereview.chromium.org/2817583004/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py (right): https://codereview.chromium.org/2817583004/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py#newcode241 third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:241: print test_baseline_set debugging?
3 years, 8 months ago (2017-04-13 16:45:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817583004/20001
3 years, 8 months ago (2017-04-13 21:26:42 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 22:53:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ed4ab0401c27e0643fa370fc3d61...

Powered by Google App Engine
This is Rietveld 408576698