Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2817583004: rebaseline-cl: Enable filling in missing results if no results could be fetched. (Closed)
Patch Set: remove print Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
index 7a205dd6d3467b7eb85d8040fadd7f5f945fd24a..0a4de89d2b95260442b1179ae8c8d6cd0028a5ab 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
@@ -324,11 +324,24 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
return_code = self.command.execute(self.command_options(), [], self.tool)
self.assertEqual(return_code, 1)
self.assertLog([
- 'ERROR: Failed to fetch results for: Build(builder_name=\'MOCK Try Win\', build_number=5000)\n',
- 'ERROR: Results were expected to exist at:\n'
- 'https://storage.googleapis.com/chromium-layout-test-archives/MOCK_Try_Win/5000/layout-test-results/results.html\n',
- 'ERROR: If the job failed, you could retry by running:\n'
- 'git cl try -b MOCK Try Win\n'
+ 'INFO: Failed to fetch results for Build(builder_name=\'MOCK Try Win\', build_number=5000)\n',
+ 'INFO: Results URL: https://storage.googleapis.com/chromium-layout-test-archives'
+ '/MOCK_Try_Win/5000/layout-test-results/results.html\n',
+ 'INFO: Retry job by running: git cl try -b MOCK Try Win\n'
+ ])
+
+ def test_continues_with_missing_results_when_filling_results(self):
+ self.tool.buildbot.set_results(Build('MOCK Try Win', 5000), None)
+ return_code = self.command.execute(self.command_options(fill_missing=True), ['fast/dom/prototype-taco.html'], self.tool)
+ self.assertEqual(return_code, 0)
+ self.assertLog([
+ 'INFO: Failed to fetch results for Build(builder_name=\'MOCK Try Win\', build_number=5000)\n',
+ 'INFO: Results URL: https://storage.googleapis.com/chromium-layout-test-archives'
+ '/MOCK_Try_Win/5000/layout-test-results/results.html\n',
+ 'INFO: Retry job by running: git cl try -b MOCK Try Win\n',
+ 'INFO: For fast/dom/prototype-taco.html:\n',
+ 'INFO: Using Build(builder_name=\'MOCK Try Mac\', build_number=4000) to supply results for test-win-win7.\n',
+ 'INFO: Rebaselining fast/dom/prototype-taco.html\n'
])
def test_bails_when_there_are_unstaged_baselines(self):
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698