Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h b/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
index 849ceca53102ec91005801c6f588a73bf6bfe074..64790cdf03af6048d52150b54f825461b8be6100 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
+++ b/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
@@ -187,14 +187,14 @@ struct WrapperTypeInfo {
template <typename T, int offset>
inline T* GetInternalField(const v8::PersistentBase<v8::Object>& persistent) {
- ASSERT(offset < v8::Object::InternalFieldCount(persistent));
+ DCHECK_LT(offset, v8::Object::InternalFieldCount(persistent));
return reinterpret_cast<T*>(
v8::Object::GetAlignedPointerFromInternalField(persistent, offset));
}
template <typename T, int offset>
inline T* GetInternalField(v8::Local<v8::Object> wrapper) {
- ASSERT(offset < wrapper->InternalFieldCount());
+ DCHECK_LT(offset, wrapper->InternalFieldCount());
return reinterpret_cast<T*>(
wrapper->GetAlignedPointerFromInternalField(offset));
}

Powered by Google App Engine
This is Rietveld 408576698