Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
index c7f16c1518cc93afae61675e0cc31cf3f11180e2..519e7c8dd96cf4e45b233c5d4940d4da15bcaac9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
@@ -103,13 +103,13 @@ WorkerOrWorkletScriptController::WorkerOrWorkletScriptController(
execution_forbidden_(false),
rejected_promises_(RejectedPromises::Create()),
execution_state_(0) {
- ASSERT(isolate);
+ DCHECK(isolate);
world_ =
DOMWrapperWorld::Create(isolate, DOMWrapperWorld::WorldType::kWorker);
}
WorkerOrWorkletScriptController::~WorkerOrWorkletScriptController() {
- ASSERT(!rejected_promises_);
+ DCHECK(!rejected_promises_);
}
void WorkerOrWorkletScriptController::Dispose() {
@@ -339,12 +339,12 @@ bool WorkerOrWorkletScriptController::Evaluate(
}
void WorkerOrWorkletScriptController::ForbidExecution() {
- ASSERT(global_scope_->IsContextThread());
+ DCHECK(global_scope_->IsContextThread());
execution_forbidden_ = true;
}
bool WorkerOrWorkletScriptController::IsExecutionForbidden() const {
- ASSERT(global_scope_->IsContextThread());
+ DCHECK(global_scope_->IsContextThread());
return execution_forbidden_;
}

Powered by Google App Engine
This is Rietveld 408576698