Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
index eb27124bfd3d6fcffed96460d326dad862167eb5..ee792dab55673aee41ddd9ec10a756d8913891d8 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
@@ -62,10 +62,10 @@ namespace blink {
static bool HasCSSPropertyNamePrefix(const String& property_name,
const char* prefix) {
#if DCHECK_IS_ON()
- ASSERT(*prefix);
+ DCHECK(*prefix);
for (const char* p = prefix; *p; ++p)
- ASSERT(IsASCIILower(*p));
- ASSERT(property_name.length());
+ DCHECK(IsASCIILower(*p));
+ DCHECK(property_name.length());
#endif
if (ToASCIILower(property_name[0]) != prefix[0])
@@ -143,7 +143,7 @@ static CSSPropertyID CssPropertyInfo(const AtomicString& name) {
if (unresolved_property == CSSPropertyVariable)
unresolved_property = CSSPropertyInvalid;
map.insert(name, unresolved_property);
- ASSERT(!unresolved_property ||
+ DCHECK(!unresolved_property ||
CSSPropertyMetadata::IsEnabledProperty(unresolved_property));
return unresolved_property;
}
@@ -170,7 +170,7 @@ void V8CSSStyleDeclaration::namedPropertyEnumeratorCustom(
v8::Array::New(info.GetIsolate(), property_names_length);
for (unsigned i = 0; i < property_names_length; ++i) {
String key = property_names.at(i);
- ASSERT(!key.IsNull());
+ DCHECK(!key.IsNull());
if (!V8CallBoolean(properties->CreateDataProperty(
context, i, V8String(info.GetIsolate(), key))))
return;

Powered by Google App Engine
This is Rietveld 408576698