third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

index 70657a237439a815cc4ec0fb05844523690e8a70..fd7bffaced51dc58b139144aa4b36bc4cd722f8f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

@@ -101,8 +101,8 @@ class CORE_EXPORT V8PerIsolateData {

static v8::Isolate* Initialize(WebTaskRunner*);

static V8PerIsolateData* From(v8::Isolate* isolate) {

- ASSERT(isolate);

- ASSERT(isolate->GetData(gin::kEmbedderBlink));

+ DCHECK(isolate);

+ DCHECK(isolate->GetData(gin::kEmbedderBlink));

return static_cast<V8PerIsolateData*>(

isolate->GetData(gin::kEmbedderBlink));

}