Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 // objects, which are simply owned and released by V8PerIsolateData (see 94 // objects, which are simply owned and released by V8PerIsolateData (see
95 // m_threadDebugger for an example). 95 // m_threadDebugger for an example).
96 class CORE_EXPORT Data { 96 class CORE_EXPORT Data {
97 public: 97 public:
98 virtual ~Data() = default; 98 virtual ~Data() = default;
99 }; 99 };
100 100
101 static v8::Isolate* Initialize(WebTaskRunner*); 101 static v8::Isolate* Initialize(WebTaskRunner*);
102 102
103 static V8PerIsolateData* From(v8::Isolate* isolate) { 103 static V8PerIsolateData* From(v8::Isolate* isolate) {
104 ASSERT(isolate); 104 DCHECK(isolate);
105 ASSERT(isolate->GetData(gin::kEmbedderBlink)); 105 DCHECK(isolate->GetData(gin::kEmbedderBlink));
106 return static_cast<V8PerIsolateData*>( 106 return static_cast<V8PerIsolateData*>(
107 isolate->GetData(gin::kEmbedderBlink)); 107 isolate->GetData(gin::kEmbedderBlink));
108 } 108 }
109 109
110 static void WillBeDestroyed(v8::Isolate*); 110 static void WillBeDestroyed(v8::Isolate*);
111 static void Destroy(v8::Isolate*); 111 static void Destroy(v8::Isolate*);
112 static v8::Isolate* MainThreadIsolate(); 112 static v8::Isolate* MainThreadIsolate();
113 113
114 static void EnableIdleTasks(v8::Isolate*, 114 static void EnableIdleTasks(v8::Isolate*,
115 std::unique_ptr<gin::V8IdleTaskRunner>); 115 std::unique_ptr<gin::V8IdleTaskRunner>);
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 Vector<std::unique_ptr<EndOfScopeTask>> end_of_scope_tasks_; 266 Vector<std::unique_ptr<EndOfScopeTask>> end_of_scope_tasks_;
267 std::unique_ptr<Data> thread_debugger_; 267 std::unique_ptr<Data> thread_debugger_;
268 268
269 Persistent<ActiveScriptWrappableSet> active_script_wrappables_; 269 Persistent<ActiveScriptWrappableSet> active_script_wrappables_;
270 std::unique_ptr<ScriptWrappableVisitor> script_wrappable_visitor_; 270 std::unique_ptr<ScriptWrappableVisitor> script_wrappable_visitor_;
271 }; 271 };
272 272
273 } // namespace blink 273 } // namespace blink
274 274
275 #endif // V8PerIsolateData_h 275 #endif // V8PerIsolateData_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698