Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
index 475bd3cb44eea3856823a5b37e360e8272276850..dcb8c84f8b12b25e356d2310cff5e53fc6cf4237 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -45,7 +45,7 @@ namespace blink {
static V8PerIsolateData* g_main_thread_per_isolate_data = 0;
static void BeforeCallEnteredCallback(v8::Isolate* isolate) {
- RELEASE_ASSERT(!ScriptForbiddenScope::IsScriptForbidden());
+ CHECK(!ScriptForbiddenScope::IsScriptForbidden());
}
static void MicrotasksCompletedCallback(v8::Isolate* isolate) {
@@ -75,7 +75,7 @@ V8PerIsolateData::V8PerIsolateData(WebTaskRunner* task_runner)
V8PerIsolateData::~V8PerIsolateData() {}
v8::Isolate* V8PerIsolateData::MainThreadIsolate() {
- ASSERT(g_main_thread_per_isolate_data);
+ DCHECK(g_main_thread_per_isolate_data);
return g_main_thread_per_isolate_data->GetIsolate();
}
@@ -279,7 +279,7 @@ void V8PerIsolateData::RunEndOfScopeTasks() {
tasks.Swap(end_of_scope_tasks_);
for (const auto& task : tasks)
task->Run();
- ASSERT(end_of_scope_tasks_.IsEmpty());
+ DCHECK(end_of_scope_tasks_.IsEmpty());
}
void V8PerIsolateData::ClearEndOfScopeTasks() {
@@ -288,7 +288,7 @@ void V8PerIsolateData::ClearEndOfScopeTasks() {
void V8PerIsolateData::SetThreadDebugger(
std::unique_ptr<V8PerIsolateData::Data> thread_debugger) {
- ASSERT(!thread_debugger_);
+ DCHECK(!thread_debugger_);
thread_debugger_ = std::move(thread_debugger);
}

Powered by Google App Engine
This is Rietveld 408576698