Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptState.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptState.h b/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
index be40f2dac50d4309376d78fed968ed58bb4eb56f..de6358c4dd428f4be245cc83c5332be925fdaf33 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
@@ -77,7 +77,7 @@ class CORE_EXPORT ScriptState : public RefCounted<ScriptState> {
explicit Scope(ScriptState* script_state)
: handle_scope_(script_state->GetIsolate()),
context_(script_state->GetContext()) {
- ASSERT(script_state->ContextIsValid());
+ DCHECK(script_state->ContextIsValid());
context_->Enter();
}
@@ -122,7 +122,7 @@ class CORE_EXPORT ScriptState : public RefCounted<ScriptState> {
}
static ScriptState* From(v8::Local<v8::Context> context) {
- ASSERT(!context.IsEmpty());
+ DCHECK(!context.IsEmpty());
ScriptState* script_state =
static_cast<ScriptState*>(context->GetAlignedPointerFromEmbedderData(
kV8ContextPerContextDataIndex));

Powered by Google App Engine
This is Rietveld 408576698