third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

index 4074bca184e6d2f9abe7adac93bc069707a38043..d8151fccc83f9bdded4b16785a3b7f4975bd8646 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

@@ -40,12 +40,12 @@ ScriptState::ScriptState(v8::Local<v8::Context> context,

}

ScriptState::~ScriptState() {

- ASSERT(!per_context_data_);

- ASSERT(context_.IsEmpty());

+ DCHECK(!per_context_data_);

+ DCHECK(context_.IsEmpty());

}

void ScriptState::DetachGlobalObject() {

- ASSERT(!context_.IsEmpty());

+ DCHECK(!context_.IsEmpty());

GetContext()->DetachGlobal();

}