third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

index e11e8a8799415ebd246906c3a8752c710d76997b..b47051878c7f74b46b6cb8f7d3238c0f86faa695 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

@@ -106,7 +106,7 @@ int ScriptRegexp::Match(const String& string,

// https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/RegExp/exec

- ASSERT(!return_value.IsEmpty());

+ DCHECK(!return_value.IsEmpty());

if (!return_value->IsArray())

return -1;