Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ScriptState.h" 5 #include "bindings/core/v8/ScriptState.h"
6 6
7 #include "bindings/core/v8/V8Binding.h" 7 #include "bindings/core/v8/V8Binding.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
(...skipping 22 matching lines...) Expand all
33 : isolate_(context->GetIsolate()), 33 : isolate_(context->GetIsolate()),
34 context_(isolate_, context), 34 context_(isolate_, context),
35 world_(std::move(world)), 35 world_(std::move(world)),
36 per_context_data_(V8PerContextData::Create(context)) { 36 per_context_data_(V8PerContextData::Create(context)) {
37 DCHECK(world_); 37 DCHECK(world_);
38 context_.SetWeak(this, &ContextCollectedCallback); 38 context_.SetWeak(this, &ContextCollectedCallback);
39 context->SetAlignedPointerInEmbedderData(kV8ContextPerContextDataIndex, this); 39 context->SetAlignedPointerInEmbedderData(kV8ContextPerContextDataIndex, this);
40 } 40 }
41 41
42 ScriptState::~ScriptState() { 42 ScriptState::~ScriptState() {
43 ASSERT(!per_context_data_); 43 DCHECK(!per_context_data_);
44 ASSERT(context_.IsEmpty()); 44 DCHECK(context_.IsEmpty());
45 } 45 }
46 46
47 void ScriptState::DetachGlobalObject() { 47 void ScriptState::DetachGlobalObject() {
48 ASSERT(!context_.IsEmpty()); 48 DCHECK(!context_.IsEmpty());
49 GetContext()->DetachGlobal(); 49 GetContext()->DetachGlobal();
50 } 50 }
51 51
52 void ScriptState::DisposePerContextData() { 52 void ScriptState::DisposePerContextData() {
53 per_context_data_ = nullptr; 53 per_context_data_ = nullptr;
54 } 54 }
55 55
56 ScriptValue ScriptState::GetFromExtrasExports(const char* name) { 56 ScriptValue ScriptState::GetFromExtrasExports(const char* name) {
57 v8::HandleScope handle_scope(isolate_); 57 v8::HandleScope handle_scope(isolate_);
58 v8::Local<v8::Value> v8_value; 58 v8::Local<v8::Value> v8_value;
59 if (!GetContext() 59 if (!GetContext()
60 ->GetExtrasBindingObject() 60 ->GetExtrasBindingObject()
61 ->Get(GetContext(), V8AtomicString(GetIsolate(), name)) 61 ->Get(GetContext(), V8AtomicString(GetIsolate(), name))
62 .ToLocal(&v8_value)) 62 .ToLocal(&v8_value))
63 return ScriptValue(); 63 return ScriptValue();
64 return ScriptValue(this, v8_value); 64 return ScriptValue(this, v8_value);
65 } 65 }
66 66
67 } // namespace blink 67 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698