third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

index 6ea313aa2850804623f2255e14b5d7bbb6697f42..427aa449484c951acf98078972f69881f1eb2c77 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

@@ -59,7 +59,7 @@ class Function : public ScriptFunction {

: ScriptFunction(script_state), output_(output) {}

ScriptValue Call(ScriptValue value) override {

- ASSERT(!value.IsEmpty());

+ DCHECK(!value.IsEmpty());

*output_ = value;

return value;

}