Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
index fd6a55d4a198b58060f93f420519ea844f290628..c41f73c65b2403b890321f2645710f4869c09e8c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
@@ -65,9 +65,9 @@ ScriptPromise ScriptPromisePropertyBase::Promise(DOMWrapperWorld& world) {
}
void ScriptPromisePropertyBase::ResolveOrReject(State target_state) {
- ASSERT(GetExecutionContext());
- ASSERT(state_ == kPending);
- ASSERT(target_state == kResolved || target_state == kRejected);
+ DCHECK(GetExecutionContext());
+ DCHECK_EQ(state_, kPending);
+ DCHECK(target_state == kResolved || target_state == kRejected);
state_ = target_state;
@@ -109,7 +109,7 @@ void ScriptPromisePropertyBase::ResolveOrRejectInternal(
v8::Local<v8::Context> context = resolver->CreationContext();
switch (state_) {
case kPending:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
break;
case kResolved:
resolver->Resolve(context, ResolvedValue(isolate_, context->Global()))
@@ -169,13 +169,13 @@ void ScriptPromisePropertyBase::ClearWrappers() {
}
void ScriptPromisePropertyBase::CheckThis() {
- RELEASE_ASSERT(this);
+ CHECK(this);
}
void ScriptPromisePropertyBase::CheckWrappers() {
for (WeakPersistentSet::iterator i = wrappers_.begin(); i != wrappers_.end();
++i) {
- RELEASE_ASSERT(*i);
+ CHECK(*i);
}
}

Powered by Google App Engine
This is Rietveld 408576698