Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
index 14c96ed919b5fff0179360258bdc6b62ef2ba522..6e095b910ae12b6e7047645d804a0cdf55bd4b29 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
@@ -156,7 +156,7 @@ v8::Local<v8::Value>
ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::ResolvedValue(
v8::Isolate* isolate,
v8::Local<v8::Object> creation_context) {
- ASSERT(GetState() == kResolved);
+ DCHECK_EQ(GetState(), kResolved);
if (!resolved_with_undefined_)
return ToV8(resolved_, creation_context, isolate);
return v8::Undefined(isolate);
@@ -167,7 +167,7 @@ v8::Local<v8::Value>
ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::RejectedValue(
v8::Isolate* isolate,
v8::Local<v8::Object> creation_context) {
- ASSERT(GetState() == kRejected);
+ DCHECK_EQ(GetState(), kRejected);
return ToV8(rejected_, creation_context, isolate);
}

Powered by Google App Engine
This is Rietveld 408576698