Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
index d2c360e3c3bc53b96bc61e38d955094aedc89651..8553ae43683d5adc70fd347880dcf4fa9d24b8f8 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
@@ -52,7 +52,7 @@ class CORE_EXPORT ScriptPromiseResolver
// - this resolver is destructed before it is resolved, rejected,
// detached, the V8 isolate is terminated or the associated
// ExecutionContext is stopped.
- ASSERT(state_ == kDetached || !is_promise_called_ ||
+ DCHECK(state_ == kDetached || !is_promise_called_ ||
!GetScriptState()->ContextIsValid() || !GetExecutionContext() ||
GetExecutionContext()->IsContextDestroyed());
}
@@ -122,7 +122,7 @@ class CORE_EXPORT ScriptPromiseResolver
if (state_ != kPending || !GetScriptState()->ContextIsValid() ||
!GetExecutionContext() || GetExecutionContext()->IsContextDestroyed())
return;
- ASSERT(new_state == kResolving || new_state == kRejecting);
+ DCHECK(new_state == kResolving || new_state == kRejecting);
state_ = new_state;
ScriptState::Scope scope(script_state_.Get());

Powered by Google App Engine
This is Rietveld 408576698