Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp
index dc76a1d63515300581b38b714fc06bd9b9c1d82a..088561f465efdbbf1c9f97e6493062d99dc364c4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp
@@ -104,7 +104,7 @@ class PromiseAllHandler final
PromiseAllHandler(ScriptState* script_state, Vector<ScriptPromise> promises)
: number_of_pending_promises_(promises.size()), resolver_(script_state) {
- ASSERT(!promises.IsEmpty());
+ DCHECK(!promises.IsEmpty());
values_.Resize(promises.size());
for (size_t i = 0; i < promises.size(); ++i)
promises[i].Then(CreateFulfillFunction(script_state, i),
@@ -126,7 +126,7 @@ class PromiseAllHandler final
if (is_settled_)
return;
- ASSERT(index < values_.size());
+ DCHECK_LT(index, values_.size());
values_[index] = value;
if (--number_of_pending_promises_ > 0)
return;
@@ -151,7 +151,7 @@ class PromiseAllHandler final
}
void MarkPromiseSettled() {
- ASSERT(!is_settled_);
+ DCHECK(!is_settled_);
is_settled_ = true;
values_.Clear();
}
@@ -242,7 +242,7 @@ ScriptPromise ScriptPromise::Then(v8::Local<v8::Function> on_fulfilled,
v8::Local<v8::Object> promise = promise_.V8Value().As<v8::Object>();
- ASSERT(promise->IsPromise());
+ DCHECK(promise->IsPromise());
// Return this Promise if no handlers are given.
// In fact it is not the exact bahavior of Promise.prototype.then
// but that is not a problem in this case.
@@ -301,7 +301,7 @@ ScriptPromise ScriptPromise::Reject(ScriptState* script_state,
ScriptPromise ScriptPromise::RejectWithDOMException(ScriptState* script_state,
DOMException* exception) {
- ASSERT(script_state->GetIsolate()->InContext());
+ DCHECK(script_state->GetIsolate()->InContext());
return Reject(script_state,
ToV8(exception, script_state->GetContext()->Global(),
script_state->GetIsolate()));

Powered by Google App Engine
This is Rietveld 408576698