Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp b/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
index 49fd5654e93ace9f1af06845ec8828b8599ff883..5d526175a75ac5f6ca635caede60d108544c8573 100644
--- a/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
@@ -40,7 +40,7 @@ namespace blink {
v8::RetainedObjectInfo* RetainedDOMInfo::CreateRetainedDOMInfo(
uint16_t class_id,
v8::Local<v8::Value> wrapper) {
- ASSERT(class_id == WrapperTypeInfo::kNodeClassId);
+ DCHECK_EQ(class_id, WrapperTypeInfo::kNodeClassId);
if (!wrapper->IsObject())
return 0;
Node* node = V8Node::toImpl(wrapper.As<v8::Object>());
@@ -48,7 +48,7 @@ v8::RetainedObjectInfo* RetainedDOMInfo::CreateRetainedDOMInfo(
}
RetainedDOMInfo::RetainedDOMInfo(Node* root) : root_(root) {
- ASSERT(root_);
+ DCHECK(root_);
}
RetainedDOMInfo::~RetainedDOMInfo() {}
@@ -58,7 +58,7 @@ void RetainedDOMInfo::Dispose() {
}
bool RetainedDOMInfo::IsEquivalent(v8::RetainedObjectInfo* other) {
- ASSERT(other);
+ DCHECK(other);
if (other == this)
return true;
if (strcmp(GetLabel(), other->GetLabel()))

Powered by Google App Engine
This is Rietveld 408576698