Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 22 matching lines...) Expand all
33 #include "bindings/core/v8/V8Node.h" 33 #include "bindings/core/v8/V8Node.h"
34 #include "bindings/core/v8/WrapperTypeInfo.h" 34 #include "bindings/core/v8/WrapperTypeInfo.h"
35 #include "core/dom/ContainerNode.h" 35 #include "core/dom/ContainerNode.h"
36 #include "core/dom/NodeTraversal.h" 36 #include "core/dom/NodeTraversal.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 v8::RetainedObjectInfo* RetainedDOMInfo::CreateRetainedDOMInfo( 40 v8::RetainedObjectInfo* RetainedDOMInfo::CreateRetainedDOMInfo(
41 uint16_t class_id, 41 uint16_t class_id,
42 v8::Local<v8::Value> wrapper) { 42 v8::Local<v8::Value> wrapper) {
43 ASSERT(class_id == WrapperTypeInfo::kNodeClassId); 43 DCHECK_EQ(class_id, WrapperTypeInfo::kNodeClassId);
44 if (!wrapper->IsObject()) 44 if (!wrapper->IsObject())
45 return 0; 45 return 0;
46 Node* node = V8Node::toImpl(wrapper.As<v8::Object>()); 46 Node* node = V8Node::toImpl(wrapper.As<v8::Object>());
47 return node ? new RetainedDOMInfo(node) : nullptr; 47 return node ? new RetainedDOMInfo(node) : nullptr;
48 } 48 }
49 49
50 RetainedDOMInfo::RetainedDOMInfo(Node* root) : root_(root) { 50 RetainedDOMInfo::RetainedDOMInfo(Node* root) : root_(root) {
51 ASSERT(root_); 51 DCHECK(root_);
52 } 52 }
53 53
54 RetainedDOMInfo::~RetainedDOMInfo() {} 54 RetainedDOMInfo::~RetainedDOMInfo() {}
55 55
56 void RetainedDOMInfo::Dispose() { 56 void RetainedDOMInfo::Dispose() {
57 delete this; 57 delete this;
58 } 58 }
59 59
60 bool RetainedDOMInfo::IsEquivalent(v8::RetainedObjectInfo* other) { 60 bool RetainedDOMInfo::IsEquivalent(v8::RetainedObjectInfo* other) {
61 ASSERT(other); 61 DCHECK(other);
62 if (other == this) 62 if (other == this)
63 return true; 63 return true;
64 if (strcmp(GetLabel(), other->GetLabel())) 64 if (strcmp(GetLabel(), other->GetLabel()))
65 return false; 65 return false;
66 return static_cast<blink::RetainedObjectInfo*>(other) 66 return static_cast<blink::RetainedObjectInfo*>(other)
67 ->GetEquivalenceClass() == this->GetEquivalenceClass(); 67 ->GetEquivalenceClass() == this->GetEquivalenceClass();
68 } 68 }
69 69
70 intptr_t RetainedDOMInfo::GetHash() { 70 intptr_t RetainedDOMInfo::GetHash() {
71 return PtrHash<void>::GetHash(root_); 71 return PtrHash<void>::GetHash(root_);
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 121
122 intptr_t SuspendableObjectsInfo::GetElementCount() { 122 intptr_t SuspendableObjectsInfo::GetElementCount() {
123 return number_of_objects_with_pending_activity_; 123 return number_of_objects_with_pending_activity_;
124 } 124 }
125 125
126 intptr_t SuspendableObjectsInfo::GetEquivalenceClass() { 126 intptr_t SuspendableObjectsInfo::GetEquivalenceClass() {
127 return reinterpret_cast<intptr_t>(this); 127 return reinterpret_cast<intptr_t>(this);
128 } 128 }
129 129
130 } // namespace blink 130 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698