Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
index 7db3171ec863ca6e51e1012b928de3cb934da6e2..9a7679f48e0fcacf61f64e683b4f4e86c5117a90 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
@@ -51,7 +51,7 @@ ScheduledAction* ScheduledAction::Create(ScriptState* script_state,
ExecutionContext* target,
const ScriptValue& handler,
const Vector<ScriptValue>& arguments) {
- ASSERT(handler.IsFunction());
+ DCHECK(handler.IsFunction());
if (!script_state->World().IsWorkerWorld()) {
if (!BindingSecurity::ShouldAllowAccessToFrame(
EnteredDOMWindow(script_state->GetIsolate()),
@@ -114,7 +114,7 @@ ScheduledAction::ScheduledAction(ScriptState* script_state,
const ScriptValue& function,
const Vector<ScriptValue>& arguments)
: script_state_(script_state), info_(script_state->GetIsolate()) {
- ASSERT(function.IsFunction());
+ DCHECK(function.IsFunction());
function_.Set(script_state->GetIsolate(),
v8::Local<v8::Function>::Cast(function.V8Value()));
info_.ReserveCapacity(arguments.size());
@@ -166,7 +166,7 @@ void ScheduledAction::Execute(LocalFrame* frame) {
}
void ScheduledAction::Execute(WorkerGlobalScope* worker) {
- ASSERT(worker->GetThread()->IsCurrentThread());
+ DCHECK(worker->GetThread()->IsCurrentThread());
if (!script_state_->ContextIsValid()) {
DVLOG(1) << "ScheduledAction::execute " << this << ": context is empty";

Powered by Google App Engine
This is Rietveld 408576698