third_party/WebKit/Source/bindings/core/v8/Dictionary.h - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/Dictionary.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/Dictionary.h b/third_party/WebKit/Source/bindings/core/v8/Dictionary.h

index 31ac02347805bbb7c996ec592d32ccc3c409aecc..4b6a68ee23fafe518a7a05d1453c06a03014f110 100644

--- a/third_party/WebKit/Source/bindings/core/v8/Dictionary.h

+++ b/third_party/WebKit/Source/bindings/core/v8/Dictionary.h

@@ -86,7 +86,7 @@ class CORE_EXPORT Dictionary final {

v8::Isolate* GetIsolate() const { return isolate_; }

v8::Local<v8::Context> V8Context() const {

- ASSERT(isolate_);

+ DCHECK(isolate_);

return isolate_->GetCurrentContext();

}