third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

index 67dae7aa1363e8cdf34bb3d9f8a3eba679e5c03d..4b6ed82998a6969d1aa0bdd792d188a8dce8ff24 100644

--- a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

@@ -96,8 +96,8 @@ bool Dictionary::Get(const StringView& key, Dictionary& value) const {

return false;

if (v8_value->IsObject()) {

- ASSERT(isolate_);

- ASSERT(isolate_ == v8::Isolate::GetCurrent());

+ DCHECK(isolate_);

+ DCHECK_EQ(isolate_, v8::Isolate::GetCurrent());

// TODO(bashi,yukishiino): Should rethrow the exception.

// http://crbug.com/666661

DummyExceptionStateForTesting exception_state;