Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 bool Get(const StringView& key, Dictionary&) const; 79 bool Get(const StringView& key, Dictionary&) const;
80 80
81 HashMap<String, String> GetOwnPropertiesAsStringHashMap( 81 HashMap<String, String> GetOwnPropertiesAsStringHashMap(
82 ExceptionState&) const; 82 ExceptionState&) const;
83 Vector<String> GetPropertyNames(ExceptionState&) const; 83 Vector<String> GetPropertyNames(ExceptionState&) const;
84 84
85 bool HasProperty(const StringView& key, ExceptionState&) const; 85 bool HasProperty(const StringView& key, ExceptionState&) const;
86 86
87 v8::Isolate* GetIsolate() const { return isolate_; } 87 v8::Isolate* GetIsolate() const { return isolate_; }
88 v8::Local<v8::Context> V8Context() const { 88 v8::Local<v8::Context> V8Context() const {
89 ASSERT(isolate_); 89 DCHECK(isolate_);
90 return isolate_->GetCurrentContext(); 90 return isolate_->GetCurrentContext();
91 } 91 }
92 92
93 DictionaryIterator GetIterator(ExecutionContext*) const; 93 DictionaryIterator GetIterator(ExecutionContext*) const;
94 94
95 private: 95 private:
96 bool GetInternal(const v8::Local<v8::Value>& key, 96 bool GetInternal(const v8::Local<v8::Value>& key,
97 v8::Local<v8::Value>& result) const; 97 v8::Local<v8::Value>& result) const;
98 98
99 v8::Isolate* isolate_; 99 v8::Isolate* isolate_;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 static bool Get(const Dictionary&, 146 static bool Get(const Dictionary&,
147 const StringView& key, 147 const StringView& key,
148 PointerType<T>& value); 148 PointerType<T>& value);
149 template <typename T> 149 template <typename T>
150 static bool Get(const Dictionary&, const StringView& key, Nullable<T>& value); 150 static bool Get(const Dictionary&, const StringView& key, Nullable<T>& value);
151 }; 151 };
152 152
153 } // namespace blink 153 } // namespace blink
154 154
155 #endif // Dictionary_h 155 #endif // Dictionary_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698