third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

index d2a5b0c1b60cc3c108c54ed480601db863c320a9..24556b8530fbe9c0da60bcb64f8bb961edb0a507 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

@@ -294,8 +294,8 @@ CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary,

if (!v8_value->IsArray())

return false;

- ASSERT(dictionary.GetIsolate());

- ASSERT(dictionary.GetIsolate() == v8::Isolate::GetCurrent());

+ DCHECK(dictionary.GetIsolate());

+ DCHECK_EQ(dictionary.GetIsolate(), v8::Isolate::GetCurrent());

value =

ArrayValue(v8::Local<v8::Array>::Cast(v8_value), dictionary.GetIsolate());

return true;