Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
index d2a5b0c1b60cc3c108c54ed480601db863c320a9..24556b8530fbe9c0da60bcb64f8bb961edb0a507 100644
--- a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
@@ -294,8 +294,8 @@ CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary,
if (!v8_value->IsArray())
return false;
- ASSERT(dictionary.GetIsolate());
- ASSERT(dictionary.GetIsolate() == v8::Isolate::GetCurrent());
+ DCHECK(dictionary.GetIsolate());
+ DCHECK_EQ(dictionary.GetIsolate(), v8::Isolate::GetCurrent());
value =
ArrayValue(v8::Local<v8::Array>::Cast(v8_value), dictionary.GetIsolate());
return true;

Powered by Google App Engine
This is Rietveld 408576698