third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp b/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

index 7a5777356c2b31c603efb185f2fc129b6b2e1220..7bc85fa2ecc001d1805f7f12671ee7897ae9425f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp

@@ -73,7 +73,7 @@ bool DocumentWriteEvaluator::EnsureEvaluationContext() {

if (!persistent_context_.IsEmpty())

return false;

TRACE_EVENT0("blink", "DocumentWriteEvaluator::initializeEvaluationContext");

- ASSERT(persistent_context_.IsEmpty());

+ DCHECK(persistent_context_.IsEmpty());

v8::Isolate* isolate = V8PerIsolateData::MainThreadIsolate();

v8::Isolate::Scope isolate_scope(isolate);

v8::HandleScope handle_scope(isolate);