Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
index 67dae7aa1363e8cdf34bb3d9f8a3eba679e5c03d..4b6ed82998a6969d1aa0bdd792d188a8dce8ff24 100644
--- a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
@@ -96,8 +96,8 @@ bool Dictionary::Get(const StringView& key, Dictionary& value) const {
return false;
if (v8_value->IsObject()) {
- ASSERT(isolate_);
- ASSERT(isolate_ == v8::Isolate::GetCurrent());
+ DCHECK(isolate_);
+ DCHECK_EQ(isolate_, v8::Isolate::GetCurrent());
// TODO(bashi,yukishiino): Should rethrow the exception.
// http://crbug.com/666661
DummyExceptionStateForTesting exception_state;

Powered by Google App Engine
This is Rietveld 408576698