Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2817513004: Fixing unused keychainError var for release builds. (Closed)

Created:
3 years, 8 months ago by nicholss
Modified:
3 years, 8 months ago
Reviewers:
joedow
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing unused keychainError var for release builds. R=joedow@chromium.org Review-Url: https://codereview.chromium.org/2817513004 Cr-Commit-Position: refs/heads/master@{#464040} Committed: https://chromium.googlesource.com/chromium/src/+/fb1afab382a5636b6959ebb0db8529657292cb50

Patch Set 1 #

Patch Set 2 : LOG_IF exits. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/client/ios/host_preferences.mm View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (3 generated)
nicholss
PTAL! Thanks!!
3 years, 8 months ago (2017-04-12 15:13:07 UTC) #1
sdefresne
drive-by https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/host_preferences.mm File remoting/client/ios/host_preferences.mm (right): https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/host_preferences.mm#newcode47 remoting/client/ios/host_preferences.mm:47: LOG_IF(ERROR, !keychainError) << "Could not write to keychain."; ...
3 years, 8 months ago (2017-04-12 15:26:28 UTC) #2
joedow
lgtm
3 years, 8 months ago (2017-04-12 15:28:04 UTC) #3
nicholss
On 2017/04/12 15:26:28, sdefresne wrote: > drive-by > > https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/host_preferences.mm > File remoting/client/ios/host_preferences.mm (right): > ...
3 years, 8 months ago (2017-04-12 15:28:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817513004/20001
3 years, 8 months ago (2017-04-12 15:29:20 UTC) #6
sdefresne
On 2017/04/12 15:28:21, nicholss wrote: > On 2017/04/12 15:26:28, sdefresne wrote: > > drive-by > ...
3 years, 8 months ago (2017-04-12 15:31:11 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 15:53:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb1afab382a5636b6959ebb0db85...

Powered by Google App Engine
This is Rietveld 408576698