Fixing unused keychainError var for release builds.

Fixing unused keychainError var for release builds.

R=joedow@chromium.org

Review-Url: https://codereview.chromium.org/2817513004
Cr-Commit-Position: refs/heads/master@{#464040}
Committed: https://chromium.googlesource.com/chromium/src/+/fb1afab382a5636b6959ebb0db8529657292cb50

[nicholss, 2017-04-12 15:13:07]

PTAL! Thanks!!

[sdefresne, 2017-04-12 15:26:28]

drive-by

https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/hos...
File remoting/client/ios/host_preferences.mm (right):

https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/hos...
remoting/client/ios/host_preferences.mm:47: LOG_IF(ERROR, !keychainError) <<
"Could not write to keychain.";
Can't you use the "ignore_result" macro instead?

  NSError* keychainError =
      remoting::ios::WriteHostPreferencesToKeychain(writeData);
  ignore_result(keychainError);

  DLOG_IF(ERROR, !keychainError) << "Could not write to keychain.";

[joedow, 2017-04-12 15:28:04]

lgtm

[nicholss, 2017-04-12 15:28:21]

On 2017/04/12 15:26:28, sdefresne wrote:
> drive-by
> 
>
https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/hos...
> File remoting/client/ios/host_preferences.mm (right):
> 
>
https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/hos...
> remoting/client/ios/host_preferences.mm:47: LOG_IF(ERROR, !keychainError) <<
> "Could not write to keychain.";
> Can't you use the "ignore_result" macro instead?
> 
>   NSError* keychainError =
>       remoting::ios::WriteHostPreferencesToKeychain(writeData);
>   ignore_result(keychainError);
> 
>   DLOG_IF(ERROR, !keychainError) << "Could not write to keychain.";

We decided it would be good to see the error in release builds too but it is
handy to know about ignore_result macro so thanks!

[nicholss, 2017-04-12 15:28:54]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2017-04-12 15:29:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-12 15:31:11]

On 2017/04/12 15:28:21, nicholss wrote:
> On 2017/04/12 15:26:28, sdefresne wrote:
> > drive-by
> > 
> >
>
https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/hos...
> > File remoting/client/ios/host_preferences.mm (right):
> > 
> >
>
https://codereview.chromium.org/2817513004/diff/20001/remoting/client/ios/hos...
> > remoting/client/ios/host_preferences.mm:47: LOG_IF(ERROR, !keychainError) <<
> > "Could not write to keychain.";
> > Can't you use the "ignore_result" macro instead?
> > 
> >   NSError* keychainError =
> >       remoting::ios::WriteHostPreferencesToKeychain(writeData);
> >   ignore_result(keychainError);
> > 
> >   DLOG_IF(ERROR, !keychainError) << "Could not write to keychain.";
> 
> We decided it would be good to see the error in release builds too but it is
> handy to know about ignore_result macro so thanks!

Make sense.

[commit-bot: I haz the power, 2017-04-12 15:52:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492010934895210,
"parent_rev": "3a3243c913d98568a9b0edb4018ad3275ae2a8f0", "commit_rev":
"fb1afab382a5636b6959ebb0db8529657292cb50"}

[commit-bot: I haz the power, 2017-04-12 15:53:43]

Description was changed from

==========
Fixing unused keychainError var for release builds.

R=joedow@chromium.org
==========

to

==========
Fixing unused keychainError var for release builds.

R=joedow@chromium.org

Review-Url: https://codereview.chromium.org/2817513004
Cr-Commit-Position: refs/heads/master@{#464040}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb1afab382a5636b6959ebb0db85...
==========

[commit-bot: I haz the power, 2017-04-12 15:53:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb1afab382a5636b6959ebb0db85...