Fixing unused keychainError var for release builds.

remoting/client/ios/host_preferences.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 #import "remoting/client/ios/host_preferences.h"
 
@@ skipping 26 matching lines @@
 
 - (void)saveToKeychain {
   NSMutableDictionary* hosts = [HostPreferences loadHosts];
   [hosts setObject:self forKey:_hostId];
 
   NSData* writeData = [NSKeyedArchiver archivedDataWithRootObject:hosts];
 
   NSError* keychainError =
       remoting::ios::WriteHostPreferencesToKeychain(writeData);
 
-  DLOG_IF(ERROR, !keychainError) << "Could not write to keychain.";
+  LOG_IF(ERROR, !keychainError) << "Could not write to keychain.";

[sdefresne, 2017/04/12 15:26:28]

Can't you use the "ignore_result" macro instead?

  NSError* keychainError =
      remoting::ios::WriteHostPreferencesToKeychain(writeData);
  ignore_result(keychainError);

  DLOG_IF(ERROR, !keychainError) << "Could not write to keychain.";
  

 }
 
 + (HostPreferences*)hostForId:(NSString*)hostId {
   NSMutableDictionary* hosts = [HostPreferences loadHosts];
   HostPreferences* host = hosts[hostId];
   if (!host) {
     host = [[HostPreferences alloc] init];
     host.hostId = hostId;
     host.pairId = @"";
     host.pairSecret = @"";
@@ skipping 25 matching lines @@
   return self;
 }
 
 - (void)encodeWithCoder:(NSCoder*)coder {
   [coder encodeObject:_hostId forKey:kHostPreferencesHostIdKey];
   [coder encodeObject:_pairId forKey:kHostPreferencesPairIdKey];
   [coder encodeObject:_pairSecret forKey:kHostPreferencesPairSecretKey];
 }
 
 @end