chrome/browser/resources/chromeos/chromevox/tools/jscompilerwrapper.py - Issue 2817313002: Support braille dot or chorded typing conversions to standard keyboard keys

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/tools/jscompilerwrapper.py

Issue 2817313002: Support braille dot or chorded typing conversions to standard keyboard keys (Closed)

Patch Set: Address feedback. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js ('k') | no next file » | no next file with comments »

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2	2

3 # Copyright 2014 The Chromium Authors. All rights reserved.	3 # Copyright 2014 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7 '''Uses the closure compiler to check syntax and semantics of a js module	7 '''Uses the closure compiler to check syntax and semantics of a js module

8 with dependencies.'''	8 with dependencies.'''

9	9

10 import os	10 import os

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 if match is None or int(match.group(1)) < 7:	57 if match is None or int(match.group(1)) < 7:

58 _Error('Java 7 or later is required: \n%s' % output)	58 _Error('Java 7 or later is required: \n%s' % output)

59	59

60 _CheckJava()	60 _CheckJava()

61	61

62	62

63 def RunCompiler(js_files, externs=[]):	63 def RunCompiler(js_files, externs=[]):

64 args = [_java_executable, '-jar', _CLOSURE_COMPILER_JAR]	64 args = [_java_executable, '-jar', _CLOSURE_COMPILER_JAR]

65 args.extend(['--compilation_level', 'SIMPLE_OPTIMIZATIONS'])	65 args.extend(['--compilation_level', 'SIMPLE_OPTIMIZATIONS'])

66 args.extend(['--jscomp_error=%s' % error for error in _JSCOMP_ERRORS])	66 args.extend(['--jscomp_error=%s' % error for error in _JSCOMP_ERRORS])

67 args.extend(['--language_in', 'ECMASCRIPT5'])	67 args.extend(['--language_in', 'ECMASCRIPT6'])

68 args.extend(['--externs=%s' % extern for extern in externs])	68 args.extend(['--externs=%s' % extern for extern in externs])

69 args.extend(['--js=%s' % js for js in js_files])	69 args.extend(['--js=%s' % js for js in js_files])

70 args.extend(['--js_output_file', '/dev/null'])	70 args.extend(['--js_output_file', '/dev/null'])

71 output = _ExecuteCommand(args, ignore_exit_status=True)	71 output = _ExecuteCommand(args, ignore_exit_status=True)

72 success = len(output) == 0	72 success = len(output) == 0

73 return success, output	73 return success, output

OLD	NEW