Chrome OS: adjust wifi icons.

Chrome OS: adjust wifi icons.

1. In the system tray, if wifi is disabled, the icon is a white wedge
   with strikethrough. If wifi is enabled and no network is connected,
   the icon is an empty wedge without a strikethrough.
2. In the default view (system bubble row) the icon is either a normal,
   badged icon if connected, an empty wedge if enabled but disconnected,
   or a full strength wedge with strikethough but with 0.54a if disabled.
3. In the notification, the icon is full strength with or without
   strikethough, depending on enabled state.

BUG=711555
Review-Url: https://codereview.chromium.org/2817223003
Cr-Commit-Position: refs/heads/master@{#464999}
Committed: https://chromium.googlesource.com/chromium/src/+/7735ed2d044b9afaa1c853f003084a55e6c6e42a

[Evan Stade, 2017-04-15 00:00:55]

Description was changed from

==========
Chrome OS: adjust wifi icons.

1. In the system tray, if wifi is disabled, the icon is a white wedge
   with strikethrough. If wifi is enabled and no network is connected,
   the icon is an empty wedge without a strikethrough.
2. In the default view (system bubble row) the icon is either a normal,
   badged icon if connected, an empty wedge if enabled but disconnected,
   or a full strength wedge with strikethough but with 0.54a if disabled.
3. In the notification, the icon is full strength with or without
   strikethough, depending on enabled state.

The "No Network" string is also changed to sentence casing.

BUG=711555
==========

to

==========
Chrome OS: adjust wifi icons.

1. In the system tray, if wifi is disabled, the icon is a white wedge
   with strikethrough. If wifi is enabled and no network is connected,
   the icon is an empty wedge without a strikethrough.
2. In the default view (system bubble row) the icon is either a normal,
   badged icon if connected, an empty wedge if enabled but disconnected,
   or a full strength wedge with strikethough but with 0.54a if disabled.
3. In the notification, the icon is full strength with or without
   strikethough, depending on enabled state.

BUG=711555
==========

[Evan Stade, 2017-04-15 00:00:59]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 00:01:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 00:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 00:39:45]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-04-17 15:17:04]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[Evan Stade, 2017-04-17 15:18:48]

estade@chromium.org changed reviewers:
+ stevenjb@chromium.org
- tdanderson@chromium.org

[Evan Stade, 2017-04-17 15:18:48]

Steven, can you take a look as Terry is ooo?

[stevenjb, 2017-04-17 16:22:52]

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
File ash/system/network/network_icon.cc (right):

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.cc:766: gfx::ImageSkia image =
GetBasicImage(true, icon_type, shill::kTypeWifi);
true /* connected */,

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.cc:938: *image = wifi_enabled ?
GetBasicImage(false, icon_type, shill::kTypeWifi)
false /* not connected */,

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.cc:939: : GetImageForWiFiChipState(false,
icon_type);
false /* not enabled */

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
File ash/system/network/network_icon.h (right):

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.h:39: ASH_EXPORT gfx::ImageSkia
GetImageForWiFiChipState(
It is unclear to me what 'ChipState' means. Maybe use 'EnabledState'?

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.h:41: IconType = ICON_TYPE_DEFAULT_VIEW);
Mostly we avoid default arguments. I'd just as soon pass this explicitly, or
have a separate wrapper method.

[Evan Stade, 2017-04-17 16:29:33]

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
File ash/system/network/network_icon.cc (right):

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.cc:766: gfx::ImageSkia image =
GetBasicImage(true, icon_type, shill::kTypeWifi);
On 2017/04/17 16:22:52, stevenjb wrote:
> true /* connected */,

Done.

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.cc:938: *image = wifi_enabled ?
GetBasicImage(false, icon_type, shill::kTypeWifi)
On 2017/04/17 16:22:52, stevenjb wrote:
> false /* not connected */,

Done.

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.cc:939: : GetImageForWiFiChipState(false,
icon_type);
On 2017/04/17 16:22:52, stevenjb wrote:
> false /* not enabled */

Done.

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
File ash/system/network/network_icon.h (right):

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.h:39: ASH_EXPORT gfx::ImageSkia
GetImageForWiFiChipState(
On 2017/04/17 16:22:52, stevenjb wrote:
> It is unclear to me what 'ChipState' means. Maybe use 'EnabledState'?

Done.

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.h:41: IconType = ICON_TYPE_DEFAULT_VIEW);
On 2017/04/17 16:22:52, stevenjb wrote:
> Mostly we avoid default arguments. I'd just as soon pass this explicitly, or
> have a separate wrapper method.

discussed offline, leaving as is.

[Evan Stade, 2017-04-17 16:29:41]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 16:29:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-04-17 16:34:11]

lgtm

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
File ash/system/network/network_icon.h (right):

https://codereview.chromium.org/2817223003/diff/1/ash/system/network/network_...
ash/system/network/network_icon.h:41: IconType = ICON_TYPE_DEFAULT_VIEW);
On 2017/04/17 16:29:33, Evan Stade wrote:
> On 2017/04/17 16:22:52, stevenjb wrote:
> > Mostly we avoid default arguments. I'd just as soon pass this explicitly, or
> > have a separate wrapper method.
> 
> discussed offline, leaving as is.

Acknowledged.

[commit-bot: I haz the power, 2017-04-17 16:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 16:42:38]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Evan Stade, 2017-04-17 19:48:20]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-04-17 19:48:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2817223003/#ps40001
(title: "update callsites")

[commit-bot: I haz the power, 2017-04-17 19:48:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:21:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492458500281800,
"parent_rev": "ce5d2adea8adbc9e950371ef08513de8e83d790d", "commit_rev":
"17ff25f18bdf44ced4dd8858cff36da9339ab439"}

[commit-bot: I haz the power, 2017-04-17 20:22:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492458500281800,
"parent_rev": "03b2a6c4aa865ddef410f4af79f7beb531ce37dd", "commit_rev":
"7735ed2d044b9afaa1c853f003084a55e6c6e42a"}

[commit-bot: I haz the power, 2017-04-17 20:22:36]

Description was changed from

==========
Chrome OS: adjust wifi icons.

1. In the system tray, if wifi is disabled, the icon is a white wedge
   with strikethrough. If wifi is enabled and no network is connected,
   the icon is an empty wedge without a strikethrough.
2. In the default view (system bubble row) the icon is either a normal,
   badged icon if connected, an empty wedge if enabled but disconnected,
   or a full strength wedge with strikethough but with 0.54a if disabled.
3. In the notification, the icon is full strength with or without
   strikethough, depending on enabled state.

BUG=711555
==========

to

==========
Chrome OS: adjust wifi icons.

1. In the system tray, if wifi is disabled, the icon is a white wedge
   with strikethrough. If wifi is enabled and no network is connected,
   the icon is an empty wedge without a strikethrough.
2. In the default view (system bubble row) the icon is either a normal,
   badged icon if connected, an empty wedge if enabled but disconnected,
   or a full strength wedge with strikethough but with 0.54a if disabled.
3. In the notification, the icon is full strength with or without
   strikethough, depending on enabled state.

BUG=711555

Review-Url: https://codereview.chromium.org/2817223003
Cr-Commit-Position: refs/heads/master@{#464999}
Committed:
https://chromium.googlesource.com/chromium/src/+/7735ed2d044b9afaa1c853f00308...
==========

[commit-bot: I haz the power, 2017-04-17 20:22:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7735ed2d044b9afaa1c853f00308...