Chrome OS: adjust wifi icons.

ash/system/network/network_icon.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_NETWORK_NETWORK_ICON_H_
 #define ASH_SYSTEM_NETWORK_NETWORK_ICON_H_
 
 #include <string>
 
 #include "ash/ash_export.h"
@@ skipping 16 matching lines @@
 };
 
 // Gets the image for provided |network|. |network| must not be NULL.
 // |icon_type| determines the color theme and whether or not to show the VPN
 // badge. This caches badged icons per network per |icon_type|.
 ASH_EXPORT gfx::ImageSkia GetImageForNetwork(
     const chromeos::NetworkState* network,
     IconType icon_type);
 
 // Gets an image for a Wi-Fi network, either full strength or strike-through
-// based on |connected|.
+// based on |enabled|.
 // TODO(estade): Expose SignalStrengthImageSource and use that instead.
-ASH_EXPORT gfx::ImageSkia GetBasicImageForWiFiNetwork(bool connected);
+ASH_EXPORT gfx::ImageSkia GetImageForWiFiChipState(

[stevenjb, 2017/04/17 16:22:52]

It is unclear to me what 'ChipState' means. Maybe use 'EnabledState'?

[Evan Stade, 2017/04/17 16:29:33]

Done.

+    bool enabled,
+    IconType = ICON_TYPE_DEFAULT_VIEW);

[stevenjb, 2017/04/17 16:22:52]

Mostly we avoid default arguments. I'd just as soon pass this explicitly, or
have a separate wrapper method.

[Evan Stade, 2017/04/17 16:29:33]

discussed offline, leaving as is.

[stevenjb, 2017/04/17 16:34:11]

Acknowledged.

 
 // Gets the disconnected image for a cell network.
 // TODO(estade): Expose SignalStrengthImageSource and use that instead.
 ASH_EXPORT gfx::ImageSkia GetImageForDisconnectedCellNetwork();
 
 // Gets the full strength image for a Wi-Fi network using |icon_color| for the
 // main icon and |badge_color| for the badge.
 ASH_EXPORT gfx::ImageSkia GetImageForNewWifiNetwork(SkColor icon_color,
                                                     SkColor badge_color);
 
@@ skipping 16 matching lines @@
 
 // Called when the list of networks changes. Retreives the list of networks
 // from the global NetworkStateHandler instance and removes cached entries
 // that are no longer in the list.
 ASH_EXPORT void PurgeNetworkIconCache();
 
 }  // namespace network_icon
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_NETWORK_NETWORK_ICON_H_