Increase the limit of command line file size

Increase the limit of command line file size

On a release channel chrome we could have field trials that take upto
10KB of the command line file. Adding browser features on telemetry
scripts sometimes take upto 4K. So, increase the limit on command line
file size.

BUG=688230, 708300
Review-Url: https://codereview.chromium.org/2817143002
Cr-Commit-Position: refs/heads/master@{#464956}
Committed: https://chromium.googlesource.com/chromium/src/+/672c3e952db98d1fb73168a8bbd12d84dbf11725

[ssid, 2017-04-13 23:45:55]

ssid@chromium.org changed reviewers:
+ perezju@chromium.org, torne@chromium.org

[ssid, 2017-04-13 23:45:56]

Is there any issue in having a safe limit on the command line size?
I just got a failure on telemetry locally even with limit 16K because of the
field trials and field trial params.

[ssid, 2017-04-13 23:46:54]

saw the discussion at https://codereview.chromium.org/2675713004. There is no
reason mentioned why 16K was chosen when we're still close to the limit!

[Torne, 2017-04-14 14:49:18]

I think it's fine to make it even bigger tbh - the only reason to have a limit
is the memory usage of the buffer and the final CommandLine instances. Just make
it 64KB now and that'll probably last us forever? (fingers crossed)

LGTM in any case.

[ssid, 2017-04-17 17:39:00]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 17:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 18:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:24:54]

Dry run: This issue passed the CQ dry run.

[ssid, 2017-04-17 18:27:14]

On 2017/04/14 14:49:18, Torne wrote:
> I think it's fine to make it even bigger tbh - the only reason to have a limit
> is the memory usage of the buffer and the final CommandLine instances. Just
make
> it 64KB now and that'll probably last us forever? (fingers crossed)
> 
> LGTM in any case.

Made it 64K, Thanks!

[ssid, 2017-04-17 18:27:18]

The CQ bit was checked by ssid@chromium.org

[ssid, 2017-04-17 18:27:18]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2817143002/#ps20001
(title: "make 64k")

[commit-bot: I haz the power, 2017-04-17 18:27:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 18:32:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492453638557370,
"parent_rev": "db88f21898176b391c397fff32e4c47282dd31ba", "commit_rev":
"672c3e952db98d1fb73168a8bbd12d84dbf11725"}

[commit-bot: I haz the power, 2017-04-17 18:32:22]

Description was changed from

==========
Increase the limit of command line file size

On a release channel chrome we could have field trials that take upto
10KB of the command line file. Adding browser features on telemetry
scripts sometimes take upto 4K. So, increase the limit on command line
file size.

BUG=688230,708300
==========

to

==========
Increase the limit of command line file size

On a release channel chrome we could have field trials that take upto
10KB of the command line file. Adding browser features on telemetry
scripts sometimes take upto 4K. So, increase the limit on command line
file size.

BUG=688230,708300

Review-Url: https://codereview.chromium.org/2817143002
Cr-Commit-Position: refs/heads/master@{#464956}
Committed:
https://chromium.googlesource.com/chromium/src/+/672c3e952db98d1fb73168a8bbd1...
==========

[commit-bot: I haz the power, 2017-04-17 18:32:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/672c3e952db98d1fb73168a8bbd1...