Increase the maximum Java command line size

Increase the maximum Java command line size

This CL increases the maximum Java command line size. The perf bots hit the 8KB
limit as a result of additions to
testing/variations/fieldtrial_testing_config.json

BUG=688230
TEST=bots green up

Review-Url: https://codereview.chromium.org/2675713004
Cr-Commit-Position: refs/heads/master@{#448429}
Committed: https://chromium.googlesource.com/chromium/src/+/6d2a4f413b7334592963360f8c7f1b1f687919b9

[pkotwicz, 2017-02-03 03:12:21]

Description was changed from

==========
Increase the maximum Java command line size

This CL increases the maximum Java command line size. The perf bots hit the 8KB
limit as a result to additions to
testing/variations/fieldtrial_testing_config.json

BUG=688230
TEST=bots green up
==========

to

==========
Increase the maximum Java command line size

This CL increases the maximum Java command line size. The perf bots hit the 8KB
limit as a result to additions to
testing/variations/fieldtrial_testing_config.json

BUG=688230
TEST=bots green up
==========

[pkotwicz, 2017-02-03 03:13:08]

Description was changed from

==========
Increase the maximum Java command line size

This CL increases the maximum Java command line size. The perf bots hit the 8KB
limit as a result to additions to
testing/variations/fieldtrial_testing_config.json

BUG=688230
TEST=bots green up
==========

to

==========
Increase the maximum Java command line size

This CL increases the maximum Java command line size. The perf bots hit the 8KB
limit as a result of additions to
testing/variations/fieldtrial_testing_config.json

BUG=688230
TEST=bots green up
==========

[pkotwicz, 2017-02-03 03:13:31]

pkotwicz@chromium.org changed reviewers:
+ torne@chromium.org

[pkotwicz, 2017-02-03 03:13:32]

torne@ can you please take a look?

[Torne, 2017-02-03 10:00:38]

lgtm

[Torne, 2017-02-03 11:03:16]

actually: not LGTM.

We should crash if the command line is too long, not just ignore it. This caused
a bunch of metrics to become nonsense; it would be much more obvious if we
failed the tests instead.

[pkotwicz, 2017-02-03 21:39:58]

pkotwicz@chromium.org changed reviewers:
+ tedchoc@chromium.org

[pkotwicz, 2017-02-03 21:39:59]

Adding tedchoc@ as a reviewer for a MTV based reviewer

tedchoc@ can you please take a look? I think that I have addressed torne@'s
comments

[pkotwicz, 2017-02-03 21:41:58]

Adding tedchoc@ as a reviewer for a MTV based reviewer

tedchoc@ can you please take a look? I think that I have addressed torne@'s
comments

I am not sure what the /data/local/chrome-command-line file is used for. I know
that it preceeded the /data/local/tmp/chrome-command-line file. It seems like
modifying chrome://flags does not write to /data/local/chrome-command-line

[Torne, 2017-02-06 12:11:52]

lgtm

[perezju, 2017-02-06 13:50:43]

On 2017/02/06 12:11:52, Torne wrote:
> lgtm

How close are we to land this? Yet another CL appears to have made us jump over
the 8KB limit, and bots are coming down again.

[pkotwicz, 2017-02-06 21:46:35]

tedchoc@ for OWNERS

[Ted C, 2017-02-06 21:48:51]

On 2017/02/06 21:46:35, pkotwicz wrote:
> tedchoc@ for OWNERS

torne@ is in owners, I'm not.

Still lgtm <shrug>

[pkotwicz, 2017-02-06 21:59:58]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-02-06 22:00:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 22:59:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486418398359390,
"parent_rev": "e44f64fb67cd9ea502dd4664e4c751c5dfc7b9c0", "commit_rev":
"6d2a4f413b7334592963360f8c7f1b1f687919b9"}

[commit-bot: I haz the power, 2017-02-06 23:00:27]

Description was changed from

==========
Increase the maximum Java command line size

This CL increases the maximum Java command line size. The perf bots hit the 8KB
limit as a result of additions to
testing/variations/fieldtrial_testing_config.json

BUG=688230
TEST=bots green up
==========

to

==========
Increase the maximum Java command line size

This CL increases the maximum Java command line size. The perf bots hit the 8KB
limit as a result of additions to
testing/variations/fieldtrial_testing_config.json

BUG=688230
TEST=bots green up

Review-Url: https://codereview.chromium.org/2675713004
Cr-Commit-Position: refs/heads/master@{#448429}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d2a4f413b7334592963360f8c7f...
==========

[commit-bot: I haz the power, 2017-02-06 23:00:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d2a4f413b7334592963360f8c7f...