Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2675713004: Increase the maximum Java command line size (Closed)

Created:
3 years, 10 months ago by pkotwicz
Modified:
3 years, 10 months ago
Reviewers:
Ted C, Torne
CC:
chromium-reviews, agrieve+watch_chromium.org, vmpstr+watch_chromium.org, perezju
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase the maximum Java command line size This CL increases the maximum Java command line size. The perf bots hit the 8KB limit as a result of additions to testing/variations/fieldtrial_testing_config.json BUG=688230 TEST=bots green up Review-Url: https://codereview.chromium.org/2675713004 Cr-Commit-Position: refs/heads/master@{#448429} Committed: https://chromium.googlesource.com/chromium/src/+/6d2a4f413b7334592963360f8c7f1b1f687919b9

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into command_line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M base/android/java/src/org/chromium/base/CommandLine.java View 1 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
pkotwicz
torne@ can you please take a look?
3 years, 10 months ago (2017-02-03 03:13:32 UTC) #4
Torne
lgtm
3 years, 10 months ago (2017-02-03 10:00:38 UTC) #5
Torne
actually: not LGTM. We should crash if the command line is too long, not just ...
3 years, 10 months ago (2017-02-03 11:03:16 UTC) #6
pkotwicz
Adding tedchoc@ as a reviewer for a MTV based reviewer tedchoc@ can you please take ...
3 years, 10 months ago (2017-02-03 21:39:59 UTC) #8
pkotwicz
Adding tedchoc@ as a reviewer for a MTV based reviewer tedchoc@ can you please take ...
3 years, 10 months ago (2017-02-03 21:41:58 UTC) #9
Torne
lgtm
3 years, 10 months ago (2017-02-06 12:11:52 UTC) #10
perezju
On 2017/02/06 12:11:52, Torne wrote: > lgtm How close are we to land this? Yet ...
3 years, 10 months ago (2017-02-06 13:50:43 UTC) #11
pkotwicz
tedchoc@ for OWNERS
3 years, 10 months ago (2017-02-06 21:46:35 UTC) #12
Ted C
On 2017/02/06 21:46:35, pkotwicz wrote: > tedchoc@ for OWNERS torne@ is in owners, I'm not. ...
3 years, 10 months ago (2017-02-06 21:48:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675713004/20001
3 years, 10 months ago (2017-02-06 22:00:35 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 23:00:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d2a4f413b7334592963360f8c7f...

Powered by Google App Engine
This is Rietveld 408576698