Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2817103002: [MD settings] hide option for incognito on session only exceptions (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] hide option for incognito on session only exceptions This CL removes the checkbox for 'incognito session only' from the add site exception dialog for 'session only' exceptions. BUG=685027 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817103002 Cr-Commit-Position: refs/heads/master@{#464634} Committed: https://chromium.googlesource.com/chromium/src/+/dfa9a8f45b3152616eabe23803befcb0673317f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/resources/settings/site_settings/add_site_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/add_site_dialog.js View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
3 years, 8 months ago (2017-04-13 23:29:53 UTC) #5
tommycli
lgtm thanks for the in-person explanation
3 years, 8 months ago (2017-04-13 23:35:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817103002/1
3 years, 8 months ago (2017-04-14 00:44:34 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 00:55:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfa9a8f45b3152616eabe23803be...

Powered by Google App Engine
This is Rietveld 408576698