Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/resources/settings/site_settings/add_site_dialog.js

Issue 2817103002: [MD settings] hide option for incognito on session only exceptions (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/add_site_dialog.js
diff --git a/chrome/browser/resources/settings/site_settings/add_site_dialog.js b/chrome/browser/resources/settings/site_settings/add_site_dialog.js
index 1e02855c308c073244b3ab1c8fd7911eac45d034..41eecca19c87a1f0f710a7097fbe8d47d099c78f 100644
--- a/chrome/browser/resources/settings/site_settings/add_site_dialog.js
+++ b/chrome/browser/resources/settings/site_settings/add_site_dialog.js
@@ -26,7 +26,7 @@ Polymer({
contentSetting: String,
/** @private */
- isIncognitoActive_: Boolean,
+ showIncognitoSessionOnly_: Boolean,
/**
* The site to add an exception for.
@@ -48,7 +48,8 @@ Polymer({
*/
open: function(type) {
this.addWebUIListener('onIncognitoStatusChanged', function(isActive) {
- this.isIncognitoActive_ = isActive;
+ this.showIncognitoSessionOnly_ = isActive &&
+ this.contentSetting != settings.PermissionValues.SESSION_ONLY;
}.bind(this));
this.browserProxy.updateIncognitoStatus();
this.$.dialog.showModal();

Powered by Google App Engine
This is Rietveld 408576698