DescriptionRevert of Adds SVGImageElement as a ImageBitmapSource (patchset #8 id:140001 of https://codereview.chromium.org/2802813002/ )
Reason for revert:
On 2017/04/13 19:02:48, commit-bot: I haz the power wrote:
> Committed patchset #8 (id:140001) as
> https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a39b0a09040cf
This is breaking some builds due to path name limits. This .rsp path is 191 characters long:
obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl/HTMLImageElementOrSVGImageElementOrHTMLVideoElementOrHTMLCanvasElementOrBlobOrImageDataOrImageBitmapOrOffscreenCanvas.obj.rsp
This is 72 characters:
C:\b\build\slave\chromium-win-x64-pgo-builder\build\src\out\Release_x64\
So that's 263. MAX_PATH in Windows is 260 (https://msdn.microsoft.com/en-us/library/cc249520.aspx).
I'm not sure why all the files are being glommed together to create the mega-path so I'm not sure what the alternative is. Presumably changing the path generation function.
Original issue's description:
> Adds SVGImageElement as a ImageBitmapSource
>
> BUG=707815
>
> Review-Url: https://codereview.chromium.org/2802813002
> Cr-Commit-Position: refs/heads/master@{#464487}
> Committed: https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a39b0a09040cf
TBR=esprehn@chromium.org,chrishtr@chromium.org,fs@opera.com,junov@chromium.org,fserb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707815
Review-Url: https://codereview.chromium.org/2817093002
Cr-Commit-Position: refs/heads/master@{#464562}
Committed: https://chromium.googlesource.com/chromium/src/+/2b8f933cd4669908b9989308505fdab3eadfff3a
Patch Set 1 #Messages
Total messages: 7 (4 generated)
|