Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2817093002: Revert of Adds SVGImageElement as a ImageBitmapSource (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, krit, fmalita+watch_chromium.org, fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds SVGImageElement as a ImageBitmapSource (patchset #8 id:140001 of https://codereview.chromium.org/2802813002/ ) Reason for revert: On 2017/04/13 19:02:48, commit-bot: I haz the power wrote: > Committed patchset #8 (id:140001) as > https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a39b0a09040cf This is breaking some builds due to path name limits. This .rsp path is 191 characters long: obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl/HTMLImageElementOrSVGImageElementOrHTMLVideoElementOrHTMLCanvasElementOrBlobOrImageDataOrImageBitmapOrOffscreenCanvas.obj.rsp This is 72 characters: C:\b\build\slave\chromium-win-x64-pgo-builder\build\src\out\Release_x64\ So that's 263. MAX_PATH in Windows is 260 (https://msdn.microsoft.com/en-us/library/cc249520.aspx). I'm not sure why all the files are being glommed together to create the mega-path so I'm not sure what the alternative is. Presumably changing the path generation function. Original issue's description: > Adds SVGImageElement as a ImageBitmapSource > > BUG=707815 > > Review-Url: https://codereview.chromium.org/2802813002 > Cr-Commit-Position: refs/heads/master@{#464487} > Committed: https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a39b0a09040cf TBR=esprehn@chromium.org,chrishtr@chromium.org,fs@opera.com,junov@chromium.org,fserb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707815 Review-Url: https://codereview.chromium.org/2817093002 Cr-Commit-Position: refs/heads/master@{#464562} Committed: https://chromium.googlesource.com/chromium/src/+/2b8f933cd4669908b9989308505fdab3eadfff3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -328 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-in-workers-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image-expected.html View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.h View 3 chunks +13 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 2 chunks +32 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/html/canvas/CanvasImageElementSource.h View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/html/canvas/CanvasImageElementSource.cpp View 1 chunk +126 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/html/canvas/ImageElementBase.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/core/html/canvas/ImageElementBase.cpp View 1 chunk +0 lines, -162 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
brucedawson
Created Revert of Adds SVGImageElement as a ImageBitmapSource
3 years, 8 months ago (2017-04-13 21:54:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817093002/1
3 years, 8 months ago (2017-04-13 21:55:14 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 21:58:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b8f933cd4669908b9989308505f...

Powered by Google App Engine
This is Rietveld 408576698