Adds SVGImageElement as a ImageBitmapSource

Adds SVGImageElement as a ImageBitmapSource

BUG=707815
Review-Url: https://codereview.chromium.org/2802813002
Cr-Original-Commit-Position: refs/heads/master@{#464487}
Committed: https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a39b0a09040cf
Review-Url: https://codereview.chromium.org/2802813002
Cr-Commit-Position: refs/heads/master@{#465882}
Committed: https://chromium.googlesource.com/chromium/src/+/dfc40833a6cfeded6637f7570ff51be6933e44dd

[fserb, 2017-04-05 21:02:15]

The CQ bit was checked by fserb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 22:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 22:17:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fserb, 2017-04-06 15:25:36]

fserb@chromium.org changed reviewers:
+ esprehn@chromium.org, junov@chromium.org

[fserb, 2017-04-06 15:25:37]

esprehn: third_party/WebKit/Source/bindings/core/v8/BUILD.gn
junov: everything else

[fserb, 2017-04-06 15:25:55]

The CQ bit was checked by fserb@chromium.org to run a CQ dry run

[fserb, 2017-04-06 15:26:23]

fserb@chromium.org changed reviewers:
+ fs@opera.com

[commit-bot: I haz the power, 2017-04-06 15:26:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-04-06 16:48:12]

This looks ok to me (lotm!), I just wish we could de-dupe the code a bit... I
feel that the resizeWidth/Height handling is a bit light on detail (spec and
code), so I can't really say if there's anything missing here wrt sizing.

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html
(right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html:28:
createImageBitmap(this).then((ib) => {
Do we have any tests for resizeWidth/Height? (I'm a bit curious to see how these
are supposed to interact with sizing negotiations...)

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:600: parseOptions(options,
cropRect, image->bitmapSourceSize());
Given all the interfaces that's defined for this, do we really need to duplicate
this much code? (I.e we use both ImageBitmapSource and CanvasImagesource here
via bitmapSourceSize and wouldTaintOrigin respectively.) It seems
HTMLImageElement should be virtually identical here.

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:91: if
(!imageElement || !imageElement->cachedImage()) {
This sequence of code also looks very similar to the HTMLImageElement case =).

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGImageElement.cpp (right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGImageElement.cpp:181:
eventTarget.toLocalDOMWindow()->document(), options));
I was a bit puzzled by this until I saw what it was used for. Passing a
SecurityOrigin as early as possible might make things more clear? (That's a task
for a different CL though.)

Also, looking at the spec it seems to say "entry settings object" (entry realm),
but wouldn't this be the global object's realm? (Also not a new issue, but worth
double-checking I think.)

[commit-bot: I haz the power, 2017-04-06 17:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 17:15:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fserb, 2017-04-06 20:06:15]

The CQ bit was checked by fserb@chromium.org

[fserb, 2017-04-06 20:06:16]

Refactored the dependency. It looks much better now that both SVGImageElement
and HTMLImageElement have a single parent that gives ImageBitmapSource and
CanvasImageSource.

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html
(right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html:28:
createImageBitmap(this).then((ib) => {
On 2017/04/06 at 16:48:12, fs wrote:
> Do we have any tests for resizeWidth/Height? (I'm a bit curious to see how
these are supposed to interact with sizing negotiations...)

I've added one simple example with resizeWidth. But I don't have any tests with
SVG images as hrefs (the ones I used for canvas don't work here because they
don't have inherit sizes). I'm not sure if this is a bug, i.e. if
<image href="xx.svg" width="10px" height="10px"> should have an inherit size
(10,10) even if xx.svg doesn't have one.

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:600: parseOptions(options,
cropRect, image->bitmapSourceSize());
On 2017/04/06 at 16:48:12, fs wrote:
> Given all the interfaces that's defined for this, do we really need to
duplicate this much code? (I.e we use both ImageBitmapSource and
CanvasImagesource here via bitmapSourceSize and wouldTaintOrigin respectively.)
It seems HTMLImageElement should be virtually identical here.

fixed

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:91: if
(!imageElement || !imageElement->cachedImage()) {
On 2017/04/06 at 16:48:12, fs wrote:
> This sequence of code also looks very similar to the HTMLImageElement case =).

done

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGImageElement.cpp (right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGImageElement.cpp:181:
eventTarget.toLocalDOMWindow()->document(), options));
On 2017/04/06 at 16:48:12, fs wrote:
> I was a bit puzzled by this until I saw what it was used for. Passing a
SecurityOrigin as early as possible might make things more clear? (That's a task
for a different CL though.)
> 
> Also, looking at the spec it seems to say "entry settings object" (entry
realm), but wouldn't this be the global object's realm? (Also not a new issue,
but worth double-checking I think.)

For the first thing, you are right.
For the second, I have no idea. :)

[fserb, 2017-04-06 20:06:20]

The CQ bit was unchecked by fserb@chromium.org

[fserb, 2017-04-06 20:06:27]

The CQ bit was checked by fserb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 20:07:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-04-06 20:27:54]

On 2017/04/06 at 20:06:16, fserb wrote:
> Refactored the dependency. It looks much better now that both SVGImageElement
and HTMLImageElement have a single parent that gives ImageBitmapSource and
CanvasImageSource.

Could also have kept CanvasImageElementSource I guess, and just added the extra
inheritance.

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html
(right):

https://codereview.chromium.org/2802813002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html:28:
createImageBitmap(this).then((ib) => {
On 2017/04/06 at 20:06:16, fserb wrote:
> On 2017/04/06 at 16:48:12, fs wrote:
> > Do we have any tests for resizeWidth/Height? (I'm a bit curious to see how
these are supposed to interact with sizing negotiations...)
> 
> I've added one simple example with resizeWidth. But I don't have any tests
with SVG images as hrefs (the ones I used for canvas don't work here because
they don't have inherit sizes). I'm not sure if this is a bug, i.e. if
> <image href="xx.svg" width="10px" height="10px"> should have an inherit size
(10,10) even if xx.svg doesn't have one.

The "intrinsic size" (not "inherit" size, but more like "inherent" size I guess)
would come from the referenced image (so for a raster image it would be the
width/height in pixels.) A case that I didn't glean from the (create)ImageBitmap
spec last I skimmed it was what a case like:

<image href="xx.svg" .../>

xx.svg:
<svg xmlns="..." viewBox="0 0 10 10">
  <rect width="10" height="10" fill="blue"/>
</svg>

and createBitmap(..., { resizeWidth: 200, resizeHeight: 100, ... });

would yield. HTMLImageElement had the same issue (if any) though I think, so
nothing new here, but probably worth checking (and fixing spec and/or code.)

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/ImageBitmap.h (right):

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/ImageBitmap.h:15: #include
"core/svg/SVGImageElement.h"
Not needed now?

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:64:
ExceptionState* exceptionState,
Was this required by anything now?

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGImageElement.cpp (right):

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGImageElement.cpp:26: #include
"core/frame/ImageBitmap.h"
No longer needed these two?

[fserb, 2017-04-06 21:03:49]

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/ImageBitmap.h (right):

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/ImageBitmap.h:15: #include
"core/svg/SVGImageElement.h"
On 2017/04/06 at 20:27:54, fs wrote:
> Not needed now?

done. Also removed HTMLImageElement.

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:64:
ExceptionState* exceptionState,
On 2017/04/06 at 20:27:54, fs wrote:
> Was this required by anything now?

It isn't. Lint was complaining that it should be either const or a pointer. Do
you want me to revert it?

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGImageElement.cpp (right):

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGImageElement.cpp:26: #include
"core/frame/ImageBitmap.h"
On 2017/04/06 at 20:27:54, fs wrote:
> No longer needed these two?

done.

[fserb, 2017-04-06 21:04:13]

The CQ bit was checked by fserb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 21:04:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-04-06 21:11:28]

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:64:
ExceptionState* exceptionState,
On 2017/04/06 at 21:03:49, fserb wrote:
> On 2017/04/06 at 20:27:54, fs wrote:
> > Was this required by anything now?
> 
> It isn't. Lint was complaining that it should be either const or a pointer. Do
you want me to revert it?

What Lint was that? (ExceptionState& is pretty much used everywhere, and
codified via the current bindings code generation, so passing them as pointers
is pretty weird.)

[blink-reviews, 2017-04-06 21:49:46]

Maybe my cpplint was high. :/ I'll revert that tomorrow.

On Thu, Apr 6, 2017 at 5:11 PM <fs@opera.com> wrote:

>
>
>
https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
> (right):
>
>
>
https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:64:
> ExceptionState* exceptionState,
> On 2017/04/06 at 21:03:49, fserb wrote:
> > On 2017/04/06 at 20:27:54, fs wrote:
> > > Was this required by anything now?
> >
> > It isn't. Lint was complaining that it should be either const or a
> pointer. Do you want me to revert it?
>
> What Lint was that? (ExceptionState& is pretty much used everywhere, and
> codified via the current bindings code generation, so passing them as
> pointers is pretty weird.)
>
> https://codereview.chromium.org/2802813002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-04-06 21:49:47]

Maybe my cpplint was high. :/ I'll revert that tomorrow.

On Thu, Apr 6, 2017 at 5:11 PM <fs@opera.com> wrote:

>
>
>
https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
> (right):
>
>
>
https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:64:
> ExceptionState* exceptionState,
> On 2017/04/06 at 21:03:49, fserb wrote:
> > On 2017/04/06 at 20:27:54, fs wrote:
> > > Was this required by anything now?
> >
> > It isn't. Lint was complaining that it should be either const or a
> pointer. Do you want me to revert it?
>
> What Lint was that? (ExceptionState& is pretty much used everywhere, and
> codified via the current bindings code generation, so passing them as
> pointers is pretty weird.)
>
> https://codereview.chromium.org/2802813002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-04-06 23:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:14:44]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-04-07 00:02:52]

esprehn@chromium.org changed reviewers:
+ chrishtr@chromium.org
- esprehn@chromium.org

[fserb, 2017-04-07 18:36:28]

done done.

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2802813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:64:
ExceptionState* exceptionState,
On 2017/04/06 at 21:11:27, fs wrote:
> On 2017/04/06 at 21:03:49, fserb wrote:
> > On 2017/04/06 at 20:27:54, fs wrote:
> > > Was this required by anything now?
> > 
> > It isn't. Lint was complaining that it should be either const or a pointer.
Do you want me to revert it?
> 
> What Lint was that? (ExceptionState& is pretty much used everywhere, and
codified via the current bindings code generation, so passing them as pointers
is pretty weird.)

done.

[fs, 2017-04-08 16:38:31]

This looks good to me (although personally I'd have stuck with the
CanvasImageElementSource naming), but I'll leave final stamping to junov & co.

Also, please file bugs for the issues with resizeWidth/Height and entry realm
(and anything else, those are the ones I remember without going back and
looking.)

[Justin Novosad, 2017-04-12 22:17:04]

https://codereview.chromium.org/2802813002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/canvas/HTMLAndSVGImageElementSource.h
(right):

https://codereview.chromium.org/2802813002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/canvas/HTMLAndSVGImageElementSource.h:18:
class CORE_EXPORT HTMLAndSVGImageElementSource : public CanvasImageSource,
I find the name of this class to be awkward. First of all the "And" should be
"Or" IMHO.  IT also sound like this is a source for an image element, which is
confusing.  The inherritance pattern is an 'X', which this class is at the
center of... How about we just call it ImageElementCommon or something simple
like that?

[fserb, 2017-04-13 15:50:48]

https://codereview.chromium.org/2802813002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/canvas/HTMLAndSVGImageElementSource.h
(right):

https://codereview.chromium.org/2802813002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/canvas/HTMLAndSVGImageElementSource.h:18:
class CORE_EXPORT HTMLAndSVGImageElementSource : public CanvasImageSource,
On 2017/04/12 at 22:17:04, Justin Novosad wrote:
> I find the name of this class to be awkward. First of all the "And" should be
"Or" IMHO.  IT also sound like this is a source for an image element, which is
confusing.  The inherritance pattern is an 'X', which this class is at the
center of... How about we just call it ImageElementCommon or something simple
like that?

ImageElementBase. Done.

[Justin Novosad, 2017-04-13 16:43:00]

lgtm

[fserb, 2017-04-13 16:57:06]

The CQ bit was checked by fserb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 16:57:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fserb, 2017-04-13 16:58:10]

fserb@chromium.org changed reviewers:
+ esprehn@chromium.org

[fserb, 2017-04-13 16:58:10]

esprehn: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

[esprehn, 2017-04-13 18:10:58]

lgtm

[commit-bot: I haz the power, 2017-04-13 18:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:38:57]

Dry run: This issue passed the CQ dry run.

[fserb, 2017-04-13 18:43:14]

The CQ bit was checked by fserb@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:43:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:01:56]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1492108994205210,
"parent_rev": "b67ca3636e3ec5dc8f38a1ffd9db79a1208620e9", "commit_rev":
"060c140872ae52c49ba012edc39a39b0a09040cf"}

[commit-bot: I haz the power, 2017-04-13 19:02:46]

Description was changed from

==========
Adds SVGImageElement as a ImageBitmapSource

BUG=707815
==========

to

==========
Adds SVGImageElement as a ImageBitmapSource

BUG=707815

Review-Url: https://codereview.chromium.org/2802813002
Cr-Commit-Position: refs/heads/master@{#464487}
Committed:
https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a...
==========

[commit-bot: I haz the power, 2017-04-13 19:02:48]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a...

[brucedawson, 2017-04-13 21:54:13]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2817093002/ by brucedawson@chromium.org.

The reason for reverting is: On 2017/04/13 19:02:48, commit-bot: I haz the power
wrote:
> Committed patchset #8 (id:140001) as
>
https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a...

This is breaking some builds due to path name limits. This .rsp path is 193
characters long:

obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl/HTMLImageElementOrSVGImageElementOrHTMLVideoElementOrHTMLCanvasElementOrBlobOrImageDataOrImageBitmapOrOffscreenCanvas.obj.rsp

This is 73 characters:

C:\b\build\slave\chromium-win-x64-pgo-builder\build\src\out\Release_x64

So that's 267. MAX_PATH in Windows is 260
(https://msdn.microsoft.com/en-us/library/cc249520.aspx).

I'm not sure why all the files are being glommed together to create the
mega-path so I'm not sure what the alternative is. Presumably changing the path
generation function.
.

[fserb, 2017-04-18 19:10:18]

fserb@chromium.org changed reviewers:
+ bashi@chromium.org

[fserb, 2017-04-18 19:10:19]

bashi: third_party/WebKit/Source/bindings/scripts/utilities.py
:)

[bashi, 2017-04-20 00:37:23]

lgtm

[fserb, 2017-04-20 01:34:35]

The CQ bit was checked by fserb@chromium.org

[fserb, 2017-04-20 01:34:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2802813002/#ps160001
(title: "x")

[commit-bot: I haz the power, 2017-04-20 01:35:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 03:17:31]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1492652075698370,
"parent_rev": "2375f72a0c62be56a6cb80fd2daff66c7748fda4", "commit_rev":
"dfc40833a6cfeded6637f7570ff51be6933e44dd"}

[commit-bot: I haz the power, 2017-04-20 03:18:09]

Description was changed from

==========
Adds SVGImageElement as a ImageBitmapSource

BUG=707815

Review-Url: https://codereview.chromium.org/2802813002
Cr-Commit-Position: refs/heads/master@{#464487}
Committed:
https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a...
==========

to

==========
Adds SVGImageElement as a ImageBitmapSource

BUG=707815

Review-Url: https://codereview.chromium.org/2802813002
Cr-Original-Commit-Position: refs/heads/master@{#464487}
Committed:
https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a...
Review-Url: https://codereview.chromium.org/2802813002
Cr-Commit-Position: refs/heads/master@{#465882}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfc40833a6cfeded6637f7570ff5...
==========

[commit-bot: I haz the power, 2017-04-20 03:18:11]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/dfc40833a6cfeded6637f7570ff5...