Adding latency_unittests to run on trybots.

Adding latency_unittests to run on trybots.

BUG=686865
Review-Url: https://codereview.chromium.org/2817063002
Cr-Commit-Position: refs/heads/master@{#465364}
Committed: https://chromium.googlesource.com/chromium/src/+/ee01a831cd8e163cec02f3ca6196dfb439e89c8f

[mfomitchev, 2017-04-13 19:58:25]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 19:58:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 20:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:05:18]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mfomitchev, 2017-04-13 20:17:27]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:17:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 20:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:30:37]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mfomitchev, 2017-04-13 21:01:10]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 21:02:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-04-13 21:16:27]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 21:16:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-04-13 21:17:06]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 21:17:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-04-13 22:08:11]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 22:08:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 22:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 22:20:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mfomitchev, 2017-04-14 02:04:48]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 02:05:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-04-14 02:08:55]

mfomitchev@chromium.org changed reviewers:
+ dpranke@chromium.org

[mfomitchev, 2017-04-14 02:08:55]

dpranke@: Do you have any idea why is presubmit for chromium.win.json failing?
Running manage.py -w has no effect, and the formatting matches the formatting
elsewhere in the file.

** Presubmit ERRORS **
manage (1.33s) failed
chromium.win.json is not in canonical format
run `testing/buildbot/manage.py -w` to fix

[commit-bot: I haz the power, 2017-04-14 02:12:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 02:12:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2017-04-14 22:32:05]

lgtm

https://codereview.chromium.org/2817063002/diff/100001/tools/valgrind/chrome_...
File tools/valgrind/chrome_tests.py (right):

https://codereview.chromium.org/2817063002/diff/100001/tools/valgrind/chrome_...
tools/valgrind/chrome_tests.py:404: return self.SimpleTest("latency",
"latency_unittests")
I'm pretty sure this file isn't used any more ...

[Dirk Pranke, 2017-04-14 22:32:45]

On 2017/04/14 02:08:55, mfomitchev wrote:
> dpranke@: Do you have any idea why is presubmit for chromium.win.json failing?
> Running manage.py -w has no effect, and the formatting matches the formatting
> elsewhere in the file.
> 
> ** Presubmit ERRORS **
> manage (1.33s) failed
> chromium.win.json is not in canonical format
> run `testing/buildbot/manage.py -w` to fix

When I patched this in locally, manage.py -w did rewrite the file (to re-sort
the targets to swap libjingle_xmpp_unittests and latency_unittests).

[mfomitchev, 2017-04-18 17:17:10]

On 2017/04/14 22:32:45, Dirk Pranke wrote:
> On 2017/04/14 02:08:55, mfomitchev wrote:
> > dpranke@: Do you have any idea why is presubmit for chromium.win.json
failing?
> > Running manage.py -w has no effect, and the formatting matches the
formatting
> > elsewhere in the file.
> > 
> > ** Presubmit ERRORS **
> > manage (1.33s) failed
> > chromium.win.json is not in canonical format
> > run `testing/buildbot/manage.py -w` to fix
> 
> When I patched this in locally, manage.py -w did rewrite the file (to re-sort
> the targets to swap libjingle_xmpp_unittests and latency_unittests).

Ah, I see. My checkout didn't have https://codereview.chromium.org/2803333002 -
you can see there's no libjingle_xmpp_unittests in the base file in the CL. It's
a bit surprising that this didn't fail at the merge step. Either way, I'll
resync and re-upload. Thanks for the help!

[mfomitchev, 2017-04-18 19:30:15]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2017-04-18 19:30:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2817063002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-18 19:30:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:55:07]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492543815053730,
"parent_rev": "b6ae0bd39e80c95a501fa2812de1d1a1ba062ea4", "commit_rev":
"ee01a831cd8e163cec02f3ca6196dfb439e89c8f"}

[commit-bot: I haz the power, 2017-04-18 20:55:13]

Description was changed from

==========
Adding latency_unittests to run on trybots.

BUG=686865
==========

to

==========
Adding latency_unittests to run on trybots.

BUG=686865

Review-Url: https://codereview.chromium.org/2817063002
Cr-Commit-Position: refs/heads/master@{#465364}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee01a831cd8e163cec02f3ca6196...
==========

[commit-bot: I haz the power, 2017-04-18 20:55:14]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/ee01a831cd8e163cec02f3ca6196...