Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2803333002: Add libjingle_xmpp_unittests to Chromium bots. (Closed)

Created:
3 years, 8 months ago by kjellander_chromium
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add libjingle_xmpp_unittests to Chromium bots. Add the libjingle_xmpp_unittests test to the following bots: Cast Audio Linux Cast Linux Android Tests Android Tests (dbg) Linux Tests Linux Tests (dbg)(1) Linux Tests (dbg)(1)(32) Mac10.10 Tests Mac10.11 Tests Mac10.9 Tests Mac10.9 Tests (dbg) Win 7 Tests x64 (1) Win10 Tests x64 Win7 Tests (1) Win7 Tests (dbg)(1) BUG=708983 TESTED=Local execution and a run in Swarming using: tools/mb/mb.py isolate //out/Release libjingle_xmpp_unittests tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i out/Release/libjingle_xmpp_unittests.isolate -s out/Release/libjingle_xmpp_unittests.isolated tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d pool Chrome -d os Linux -d cpu x86-64 out/Release/libjingle_xmpp_unittests.isolated Review-Url: https://codereview.chromium.org/2803333002 Cr-Commit-Position: refs/heads/master@{#464349} Committed: https://chromium.googlesource.com/chromium/src/+/d5fe9bf25fa23fb35b7bea2580e821b3ca8cbc79

Patch Set 1 #

Patch Set 2 : Added dependency on //base/test:test_support #

Patch Set 3 : Fully utilizing Chromium test launcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -11 lines) Patch
M testing/buildbot/chromium.linux.json View 7 chunks +92 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libjingle_xmpp/BUILD.gn View 1 2 2 chunks +2 lines, -1 line 0 comments Download
D third_party/libjingle_xmpp/run_all_unittests.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 40 (25 generated)
kjellander_chromium
These tests takes about 5 seconds to run on Linux and 18 seconds on Android...
3 years, 8 months ago (2017-04-10 12:57:22 UTC) #15
Paweł Hajdan Jr.
LGTM
3 years, 8 months ago (2017-04-11 07:49:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803333002/40001
3 years, 8 months ago (2017-04-11 08:31:28 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/407732)
3 years, 8 months ago (2017-04-11 08:40:39 UTC) #20
kjellander_chromium
+henrika@chromium.org for owners approval
3 years, 8 months ago (2017-04-11 08:53:00 UTC) #22
kjellander_chromium
swapping henrika@ (OOO) for sergeyu@
3 years, 8 months ago (2017-04-12 19:22:21 UTC) #24
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-12 21:44:53 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803333002/40001
3 years, 8 months ago (2017-04-13 04:37:02 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/361494)
3 years, 8 months ago (2017-04-13 05:42:06 UTC) #29
kjellander_chromium
On 2017/04/13 05:42:06, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-13 05:50:27 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803333002/40001
3 years, 8 months ago (2017-04-13 05:50:49 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/361559)
3 years, 8 months ago (2017-04-13 07:06:23 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803333002/40001
3 years, 8 months ago (2017-04-13 08:05:32 UTC) #36
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d5fe9bf25fa23fb35b7bea2580e821b3ca8cbc79
3 years, 8 months ago (2017-04-13 09:05:58 UTC) #39
henrika (OOO until Aug 14)
3 years, 8 months ago (2017-04-18 10:37:52 UTC) #40
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698