Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2817053003: Revert of Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL. (Closed)

Created:
3 years, 8 months ago by nednguyen
Modified:
3 years, 8 months ago
Reviewers:
davidben, mattm
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri, net-reviews_chromium.org, martijn+crwatch_martijnc.be, xunjieli
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL. (patchset #9 id:160001 of https://codereview.chromium.org/2786173003/ ) Reason for revert: Suspect causing ERR_SSL_SERVER_CERT_BAD_FORMAT error on perf tests. Original issue's description: > Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL. > > BUG=671420 > > Review-Url: https://codereview.chromium.org/2786173003 > Cr-Commit-Position: refs/heads/master@{#464262} > Committed: https://chromium.googlesource.com/chromium/src/+/0704d236ee706ffb29fc22fd90f99537e7f15673 TBR=davidben@chromium.org,mattm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671420 Review-Url: https://codereview.chromium.org/2817053003 Cr-Commit-Position: refs/heads/master@{#464715} Committed: https://chromium.googlesource.com/chromium/src/+/9a1915060877f610870645a720d8d6eb177d0a0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -39 lines) Patch
M net/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_objects_extractor.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/socket/ssl_server_socket_impl.cc View 3 chunks +15 lines, -18 lines 0 comments Download
M net/ssl/openssl_client_key_store.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M net/ssl/openssl_ssl_util.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of Convert android to use X509CertificateBytes instead of X509CertificateOpenSSL.
3 years, 8 months ago (2017-04-14 10:50:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817053003/1
3 years, 8 months ago (2017-04-14 10:50:37 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 11:51:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a1915060877f610870645a720d8...

Powered by Google App Engine
This is Rietveld 408576698