Get maximum age of clipboard from clipboard_recent_contents.cc in iOS impl

Get maximum age of clipboard from clipboard_recent_contents.cc in iOS impl

Using this time will make it possible to share logic to change it as
required in https://codereview.chromium.org/2808413003/

TBR=jif

BUG=none

Review-Url: https://codereview.chromium.org/2817003003
Cr-Commit-Position: refs/heads/master@{#464436}
Committed: https://chromium.googlesource.com/chromium/src/+/9c81c7f602788f3fc6e697a2da771e5b0e582a12

[lody, 2017-04-13 11:08:29]

lod@chromium.org changed reviewers:
+ marq@chromium.org

[lody, 2017-04-13 11:08:29]

Please review. Will TBR jif so this can land this week.

cc MarkP for info.

[lody, 2017-04-13 11:08:51]

Description was changed from

==========
Get maximum age of clipboard from clipboard_recent_contents.cc in iOS impl

Using this time will make it possible to share logic to change it as
required in https://codereview.chromium.org/2808413003/

BUG=none
==========

to

==========
Get maximum age of clipboard from clipboard_recent_contents.cc in iOS impl

Using this time will make it possible to share logic to change it as
required in https://codereview.chromium.org/2808413003/

TBR=jif

BUG=none
==========

[marq (ping after 24h), 2017-04-13 11:33:38]

https://codereview.chromium.org/2817003003/diff/1/components/open_from_clipbo...
File components/open_from_clipboard/clipboard_recent_content_impl_ios.mm
(right):

https://codereview.chromium.org/2817003003/diff/1/components/open_from_clipbo...
components/open_from_clipboard/clipboard_recent_content_impl_ios.mm:59:
@property(nonatomic) NSTimeInterval maximumAgeOfClipboard;
readonly, if this is only set in the init and never changes for the lifetime of
the object?

https://codereview.chromium.org/2817003003/diff/1/components/open_from_clipbo...
components/open_from_clipboard/clipboard_recent_content_impl_ios.mm:155: if
([self clipboardContentAge] > [self maximumAgeOfClipboard]) {
Nit: prefer dot notation (self.maximumAgeOfClipboard) for properties.

[lody, 2017-04-13 11:47:37]

https://codereview.chromium.org/2817003003/diff/1/components/open_from_clipbo...
File components/open_from_clipboard/clipboard_recent_content_impl_ios.mm
(right):

https://codereview.chromium.org/2817003003/diff/1/components/open_from_clipbo...
components/open_from_clipboard/clipboard_recent_content_impl_ios.mm:59:
@property(nonatomic) NSTimeInterval maximumAgeOfClipboard;
On 2017/04/13 11:33:38, marq wrote:
> readonly, if this is only set in the init and never changes for the lifetime
of
> the object?

Done.

https://codereview.chromium.org/2817003003/diff/1/components/open_from_clipbo...
components/open_from_clipboard/clipboard_recent_content_impl_ios.mm:155: if
([self clipboardContentAge] > [self maximumAgeOfClipboard]) {
On 2017/04/13 11:33:38, marq wrote:
> Nit: prefer dot notation (self.maximumAgeOfClipboard) for properties.

Done.

[marq (ping after 24h), 2017-04-13 13:52:09]

lgtm

[lody, 2017-04-13 13:52:27]

The CQ bit was checked by lod@chromium.org

[commit-bot: I haz the power, 2017-04-13 13:52:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 14:00:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:00:15]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lody, 2017-04-13 15:03:20]

Patchset #3 (id:40001) has been deleted

[lody, 2017-04-13 15:41:01]

The CQ bit was checked by lod@chromium.org

[lody, 2017-04-13 15:41:02]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2817003003/#ps60001
(title: "fix generic + rebase")

[commit-bot: I haz the power, 2017-04-13 15:41:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 16:33:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492098061792720,
"parent_rev": "1756a1ec21a7ebc64d5bc2837988a7b865e9c605", "commit_rev":
"9c81c7f602788f3fc6e697a2da771e5b0e582a12"}

[commit-bot: I haz the power, 2017-04-13 16:34:49]

Description was changed from

==========
Get maximum age of clipboard from clipboard_recent_contents.cc in iOS impl

Using this time will make it possible to share logic to change it as
required in https://codereview.chromium.org/2808413003/

TBR=jif

BUG=none
==========

to

==========
Get maximum age of clipboard from clipboard_recent_contents.cc in iOS impl

Using this time will make it possible to share logic to change it as
required in https://codereview.chromium.org/2808413003/

TBR=jif

BUG=none

Review-Url: https://codereview.chromium.org/2817003003
Cr-Commit-Position: refs/heads/master@{#464436}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c81c7f602788f3fc6e697a2da77...
==========

[commit-bot: I haz the power, 2017-04-13 16:34:50]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9c81c7f602788f3fc6e697a2da77...

[jif, 2017-04-18 12:16:28]

jif@chromium.org changed reviewers:
+ jif@chromium.org

[jif, 2017-04-18 12:16:29]

lgtm