Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm

Issue 2817003003: Get maximum age of clipboard from clipboard_recent_contents.cc in iOS impl (Closed)
Patch Set: fix generic + rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
diff --git a/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm b/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
index 341f0ba2f7874112386fd6cef44f97159c01e261..6a68d6e868723426d211a695f4cbae584a5455b7 100644
--- a/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
+++ b/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
@@ -46,17 +46,18 @@ const char kRecognizedURL2[] = "good://bar/2";
const char kAppSpecificURL[] = "test://qux/";
const char kAppSpecificScheme[] = "test";
const char kRecognizedScheme[] = "good";
-NSTimeInterval kSevenHours = 60 * 60 * 7;
+NSTimeInterval kLongerThanMaxAge = 60 * 60 * 7;
+NSTimeInterval kMaxAge = 60 * 60 * 1;
} // namespace
@interface ClipboardRecentContentImplIOSWithFakeUptime
: ClipboardRecentContentImplIOS
@property(nonatomic) NSTimeInterval fakeUptime;
-- (instancetype)initWithDelegate:(id<ClipboardRecentContentDelegate>)delegate
- authorizedSchemes:(NSArray*)authorizedSchemes
- userDefaults:(NSUserDefaults*)groupUserDefaults
- uptime:(NSTimeInterval)uptime;
+- (instancetype)initWithMaxAge:(NSTimeInterval)maxAge
+ authorizedSchemes:(NSArray*)authorizedSchemes
+ userDefaults:(NSUserDefaults*)groupUserDefaults
+ uptime:(NSTimeInterval)uptime;
@end
@@ -64,13 +65,14 @@ NSTimeInterval kSevenHours = 60 * 60 * 7;
@synthesize fakeUptime = _fakeUptime;
-- (instancetype)initWithDelegate:(id<ClipboardRecentContentDelegate>)delegate
- authorizedSchemes:(NSSet*)authorizedSchemes
- userDefaults:(NSUserDefaults*)groupUserDefaults
- uptime:(NSTimeInterval)uptime {
- self = [super initWithAuthorizedSchemes:authorizedSchemes
- userDefaults:groupUserDefaults
- delegate:delegate];
+- (instancetype)initWithMaxAge:(NSTimeInterval)maxAge
+ authorizedSchemes:(NSSet*)authorizedSchemes
+ userDefaults:(NSUserDefaults*)groupUserDefaults
+ uptime:(NSTimeInterval)uptime {
+ self = [super initWithMaxAge:maxAge
+ authorizedSchemes:authorizedSchemes
+ userDefaults:groupUserDefaults
+ delegate:nil];
if (self) {
_fakeUptime = uptime;
}
@@ -108,7 +110,7 @@ class ClipboardRecentContentIOSTest : public ::testing::Test {
base::TimeDelta time_delta) {
clipboard_content_implementation_ =
[[ClipboardRecentContentImplIOSWithFakeUptime alloc]
- initWithDelegate:nil
+ initWithMaxAge:kMaxAge
authorizedSchemes:@[
base::SysUTF8ToNSString(kRecognizedScheme),
base::SysUTF8ToNSString(application_scheme)
@@ -167,7 +169,7 @@ TEST_F(ClipboardRecentContentIOSTest, PasteboardURLObsolescence) {
// Test that old pasteboard data is not provided.
SetStoredPasteboardChangeDate(
- [NSDate dateWithTimeIntervalSinceNow:-kSevenHours]);
+ [NSDate dateWithTimeIntervalSinceNow:-kLongerThanMaxAge]);
EXPECT_FALSE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
// Tests that if chrome is relaunched, old pasteboard data is still
« no previous file with comments | « components/open_from_clipboard/clipboard_recent_content_ios.mm ('k') | ios/chrome/widget_extension/widget_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698