Clean up spdy_framer_test.cc.

Clean up spdy_framer_test.cc.

- Simplify some nested statements.
- Use base::MakeUnique usage.
- Replace std::unique_ptr<char[]> with std::vector<char>.

Review-Url: https://codereview.chromium.org/2816893003
Cr-Commit-Position: refs/heads/master@{#464481}
Committed: https://chromium.googlesource.com/chromium/src/+/fc9ca7bd4bedfd3731036ad17669126d67e650fe

[Lei Zhang, 2017-04-13 07:57:21]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 07:57:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 08:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 08:35:06]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-04-13 08:47:55]

thestig@chromium.org changed reviewers:
+ bnc@chromium.org

[Bence, 2017-04-13 13:21:45]

LGTM.  Nice cleanup, thank you!

[Lei Zhang, 2017-04-13 18:35:11]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:36:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 18:51:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492108511481150, "parent_rev":
"cd2ce1caaaba5275120b2bf6f2dce34c5249009c", "commit_rev":
"fc9ca7bd4bedfd3731036ad17669126d67e650fe"}

[commit-bot: I haz the power, 2017-04-13 18:52:10]

Description was changed from

==========
Clean up spdy_framer_test.cc.

- Simplify some nested statements.
- Use base::MakeUnique usage.
- Replace std::unique_ptr<char[]> with std::vector<char>.
==========

to

==========
Clean up spdy_framer_test.cc.

- Simplify some nested statements.
- Use base::MakeUnique usage.
- Replace std::unique_ptr<char[]> with std::vector<char>.

Review-Url: https://codereview.chromium.org/2816893003
Cr-Commit-Position: refs/heads/master@{#464481}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc9ca7bd4bedfd3731036ad17669...
==========

[commit-bot: I haz the power, 2017-04-13 18:52:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc9ca7bd4bedfd3731036ad17669...

[rohitrao (ping after 24h), 2017-05-09 00:46:11]

rohitrao@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-05-09 00:46:12]

I believe that this CL increased the net_unittests running time on iOS by about
300s, but I'm not sure why.  We're tracking this in crbug.com/718524.

[Lei Zhang, 2017-05-09 01:30:31]

On 2017/05/09 00:46:12, rohitrao (ping after 24h) wrote:
> I believe that this CL increased the net_unittests running time on iOS by
about
> 300s, but I'm not sure why.  We're tracking this in crbug.com/718524.

Running on Linux with
--gtest_filter=SpdyFramerTests/SpdyFramerTest.ProcessAtMostOneFrame*, I see a
~20% increase in the test time. It looks like using std::vector in debug mode
can be a serious slowdown. :(

[Lei Zhang, 2017-05-09 01:41:32]

I uploaded https://codereview.chromium.org/2861393005

When I tested locally on Linux, I went back to r464481, as the file has moved
around. I was getting ~400 ms / test with r464480 and ~500 ms / test with
r464481. When I synced back to ToT, I'm now getting ~700 ms / test. With the new
CL, it goes back down to ~600 ms / test. So there may be other changes causing
slowdowns as well. Of course, performance on iOS can be completely different.