Partial revert of a spdy_framer_test.cc clean up.

Partial revert of a spdy_framer_test.cc clean up.

This reverts part of r464481. While std::vectors are easier to manage
than C arrays, they can also be much slower in debug mode. When used
intensively in test-only code, speed becomes more important than
manageability.

BUG=718524
Review-Url: https://codereview.chromium.org/2861393005
Cr-Commit-Position: refs/heads/master@{#470466}
Committed: https://chromium.googlesource.com/chromium/src/+/4b3c5489ed733182391be9f8cfb9cae5af1f1b3f

[Lei Zhang, 2017-05-09 01:55:43]

thestig@chromium.org changed reviewers:
+ bnc@chromium.org

[Lei Zhang, 2017-05-09 05:25:30]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 05:26:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 06:09:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 06:09:14]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-05-09 12:30:32]

Looks like this will make a big difference!  Thanks for looking at this so
quickly!

From an iOS bot on the main waterfall:
832 tests from SpdyFramerTests/SpdyFramerTest (231874 ms total)

And from the ios-simulator tryjob on this CL:
832 tests from SpdyFramerTests/SpdyFramerTest (7888 ms total)

[Lei Zhang, 2017-05-09 18:47:47]

bnc: Please review.

Wow, that's a lot of debugging overhead on iOS.

[Bence, 2017-05-09 23:14:13]

On 2017/05/09 18:47:47, Lei Zhang wrote:
> bnc: Please review.
> 
> Wow, that's a lot of debugging overhead on iOS.

LGTM, thank you.

[Lei Zhang, 2017-05-09 23:15:00]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-05-09 23:16:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 01:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:20:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Lei Zhang, 2017-05-10 04:52:39]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:53:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 05:04:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494391959120190, "parent_rev":
"ec187eecfd39a18cb94f43132858c2f7b3525cc8", "commit_rev":
"4b3c5489ed733182391be9f8cfb9cae5af1f1b3f"}

[commit-bot: I haz the power, 2017-05-10 05:05:03]

Description was changed from

==========
Partial revert of a spdy_framer_test.cc clean up.

This reverts part of r464481. While std::vectors are easier to manage
than C arrays, they can also be much slower in debug mode. When used
intensively in test-only code, speed becomes more important than
manageability.

BUG=718524
==========

to

==========
Partial revert of a spdy_framer_test.cc clean up.

This reverts part of r464481. While std::vectors are easier to manage
than C arrays, they can also be much slower in debug mode. When used
intensively in test-only code, speed becomes more important than
manageability.

BUG=718524

Review-Url: https://codereview.chromium.org/2861393005
Cr-Commit-Position: refs/heads/master@{#470466}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b3c5489ed733182391be9f8cfb9...
==========

[commit-bot: I haz the power, 2017-05-10 05:05:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b3c5489ed733182391be9f8cfb9...