Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2816833002: VR: Fix dynamic resizing webVR page, revert FOV calculation changes. (Closed)

Created:
3 years, 8 months ago by mthiesse
Modified:
3 years, 8 months ago
Reviewers:
cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Fix dynamic resizing webVR page, revert FOV calculation changes. BUG= Review-Url: https://codereview.chromium.org/2816833002 Cr-Commit-Position: refs/heads/master@{#464245} Committed: https://chromium.googlesource.com/chromium/src/+/9cc98580c28a6c26cddd7d1fbfeeeaf526ff9a15

Patch Set 1 #

Patch Set 2 : Correct diffbase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 6 chunks +49 lines, -16 lines 0 comments Download
M device/vr/vr_math.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/vr/vr_math.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 8 months ago (2017-04-12 21:56:37 UTC) #2
cjgrant
lgtm
3 years, 8 months ago (2017-04-12 22:51:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816833002/20001
3 years, 8 months ago (2017-04-12 23:00:45 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 02:11:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9cc98580c28a6c26cddd7d1fbfee...

Powered by Google App Engine
This is Rietveld 408576698