Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2816713004:
Geolocation: rename Geoposition to Position to follow Spec (take 2) (Closed)
|
Created:
3 years, 8 months ago by mcasas Modified:
3 years, 8 months ago Reviewers:
foolip CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, timvolodine, mvanouwerkerk+watch_chromium.org, mcasas+geolocation_chromium.org, haraken Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionGeolocation: rename Geoposition to Position to follow Spec (take 2)
CL https://crrev.com/2809843002 took a stab at it but clashed with
the definition in [1]:
using Position = PositionTemplate<EditingStrategy>;
which is, sadly, used in a bazillion places (see e.g. [2]).
This CL takes a least bad solution by renaming the idl-exposed
Geoposition to Position, but keeping the underlying c++ classes
unchanged.
BUG=708206
[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/Position.h?dr&sq=package:chromium&l=224
[2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/WebKit/Source/core/+package:%5Ewebrtc$&type=cs
Review-Url: https://codereview.chromium.org/2816713004
Cr-Commit-Position: refs/heads/master@{#464321}
Committed: https://chromium.googlesource.com/chromium/src/+/c73d5721559290e45c7d3aa8b5d1a5ef6caaade8
Patch Set 1 : #
Messages
Total messages: 24 (20 generated)
Description was changed from ========== RELAND: Geolocation: rename Geoposition to Position to follow Spec The original CL got reverted due to a clash with other Position, in [1]: using Position = PositionTemplate<EditingStrategy>; This CL avoids that collision. [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... Original CL description ------------------------------------------------ Geolocation: rename Geoposition to Position to follow Spec Renamed Geoposition to Position to align with the spec [1] and rippled that change through the files. This change does not surface to the Web platform since Geoposition is a NoInterfaceObject _except_ for the way Geoposition is stringified, which changes to "[object Position]". [1] https://www.w3.org/TR/geolocation-API/#position_interface BUG=708206 Review-Url: https://codereview.chromium.org/2809843002 Cr-Commit-Position: refs/heads/master@{#463759} Committed: https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429... patch from issue 2809843002 at patchset 80001 (http://crrev.com/2809843002#ps80001) ========== to ========== RELAND: Geolocation: rename Geoposition to Position to follow Spec The original CL got reverted due to a clash with other Position, in [1]: using Position = PositionTemplate<EditingStrategy>; This CL avoids that collision. [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... Original CL description ------------------------------------------------ Geolocation: rename Geoposition to Position to follow Spec Renamed Geoposition to Position to align with the spec [1] and rippled that change through the files. This change does not surface to the Web platform since Geoposition is a NoInterfaceObject _except_ for the way Geoposition is stringified, which changes to "[object Position]". [1] https://www.w3.org/TR/geolocation-API/#position_interface BUG=708206 Review-Url: https://codereview.chromium.org/2809843002 Cr-Commit-Position: refs/heads/master@{#463759} Committed: https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429... patch from issue 2809843002 at patchset 80001 (http://crrev.com/2809843002#ps80001) ==========
Description was changed from ========== RELAND: Geolocation: rename Geoposition to Position to follow Spec The original CL got reverted due to a clash with other Position, in [1]: using Position = PositionTemplate<EditingStrategy>; This CL avoids that collision. [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... Original CL description ------------------------------------------------ Geolocation: rename Geoposition to Position to follow Spec Renamed Geoposition to Position to align with the spec [1] and rippled that change through the files. This change does not surface to the Web platform since Geoposition is a NoInterfaceObject _except_ for the way Geoposition is stringified, which changes to "[object Position]". [1] https://www.w3.org/TR/geolocation-API/#position_interface BUG=708206 Review-Url: https://codereview.chromium.org/2809843002 Cr-Commit-Position: refs/heads/master@{#463759} Committed: https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429... patch from issue 2809843002 at patchset 80001 (http://crrev.com/2809843002#ps80001) ========== to ========== RELAND: Geolocation: rename Geoposition to Position to follow Spec The original CL got reverted due to a clash with other Position, in [1]: using Position = PositionTemplate<EditingStrategy>; This CL renames this 'Position' (can't use an anonymous namespace because it's a header file). [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... Original CL description ------------------------------------------------ Geolocation: rename Geoposition to Position to follow Spec Renamed Geoposition to Position to align with the spec [1] and rippled that change through the files. This change does not surface to the Web platform since Geoposition is a NoInterfaceObject _except_ for the way Geoposition is stringified, which changes to "[object Position]". [1] https://www.w3.org/TR/geolocation-API/#position_interface BUG=708206 Review-Url: https://codereview.chromium.org/2809843002 Cr-Commit-Position: refs/heads/master@{#463759} Committed: https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429... patch from issue 2809843002 at patchset 80001 (http://crrev.com/2809843002#ps80001) ==========
Patchset #2 (id:20001) has been deleted
Description was changed from ========== RELAND: Geolocation: rename Geoposition to Position to follow Spec The original CL got reverted due to a clash with other Position, in [1]: using Position = PositionTemplate<EditingStrategy>; This CL renames this 'Position' (can't use an anonymous namespace because it's a header file). [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... Original CL description ------------------------------------------------ Geolocation: rename Geoposition to Position to follow Spec Renamed Geoposition to Position to align with the spec [1] and rippled that change through the files. This change does not surface to the Web platform since Geoposition is a NoInterfaceObject _except_ for the way Geoposition is stringified, which changes to "[object Position]". [1] https://www.w3.org/TR/geolocation-API/#position_interface BUG=708206 Review-Url: https://codereview.chromium.org/2809843002 Cr-Commit-Position: refs/heads/master@{#463759} Committed: https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429... patch from issue 2809843002 at patchset 80001 (http://crrev.com/2809843002#ps80001) ========== to ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ========== to ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ==========
Description was changed from ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. [1] https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/core/editing/Pos... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ========== to ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ==========
Description was changed from ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ========== to ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ==========
Description was changed from ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ========== to ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ==========
Description was changed from ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ========== to ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ==========
mcasas@chromium.org changed reviewers: + foolip@chromium.org
foolip@ ptal
Description was changed from ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion of places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ========== to ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ==========
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by foolip@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492063301374210,
"parent_rev": "8bc32204bc129658adab8e1fb8be3058c723e6ca", "commit_rev":
"c73d5721559290e45c7d3aa8b5d1a5ef6caaade8"}
Message was sent while issue was closed.
Description was changed from ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... ========== to ========== Geolocation: rename Geoposition to Position to follow Spec (take 2) CL https://crrev.com/2809843002 took a stab at it but clashed with the definition in [1]: using Position = PositionTemplate<EditingStrategy>; which is, sadly, used in a bazillion places (see e.g. [2]). This CL takes a least bad solution by renaming the idl-exposed Geoposition to Position, but keeping the underlying c++ classes unchanged. BUG=708206 [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/P... [2] https://cs.chromium.org/search/?q=%22+Position+%22+file:%5Esrc/third_party/We... Review-Url: https://codereview.chromium.org/2816713004 Cr-Commit-Position: refs/heads/master@{#464321} Committed: https://chromium.googlesource.com/chromium/src/+/c73d5721559290e45c7d3aa8b5d1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c73d5721559290e45c7d3aa8b5d1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
